Skip to content

Fa-pull-undefined #488

@kav-viasat

Description

@kav-viasat

Describe the problem

The fa-pull-undefined and fa-undefined classes come from the FaIconComponent in @fortawesome/angular-fontawesome.

It comes from a bug in @fortawesome/angular-fontawesome v3.0.0. In the library's class-building logic at line 123 of its bundle:

[fa-pull-${props.pull}]: props.pull !== null,

The guard only checks for null, not undefined. Since the pull input (now an Angular signal via input()) defaults to undefined when not set, the condition undefined !== null evaluates to true — so fa-pull-undefined gets added. The same issue applies to size (fa-undefined) and the removal of focusable and xmlns attributes.

This is a regression in v3.0.0. This wasn't the case in version 1, it seems to be the case in version 2 onwards

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions