From 1422eba23c36a47dcc446936c448c01aee86d150 Mon Sep 17 00:00:00 2001 From: Mike Wilkerson <11575183+mlwilkerson@users.noreply.github.com> Date: Wed, 24 Sep 2025 12:02:34 -0700 Subject: [PATCH 1/2] remove the version-based condition on the loading of svg.css vs. svg-with-js.css --- includes/class-fontawesome-release-provider.php | 4 +--- includes/class-fontawesome-svg-styles-manager.php | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/includes/class-fontawesome-release-provider.php b/includes/class-fontawesome-release-provider.php index 9810cd22b..67ac2f385 100644 --- a/includes/class-fontawesome-release-provider.php +++ b/includes/class-fontawesome-release-provider.php @@ -552,9 +552,7 @@ public static function get_option() { * @return FontAwesome_Resource */ public function get_svg_styles_resource( $version ) { - $file_basename = ( is_string( $version ) && strlen( $version ) > 0 && '7' === $version[0] ) - ? 'svg' - : 'svg-with-js'; + $file_basename = 'svg-with-js'; $cdn_url_template = null; diff --git a/includes/class-fontawesome-svg-styles-manager.php b/includes/class-fontawesome-svg-styles-manager.php index 26baa0113..691244594 100644 --- a/includes/class-fontawesome-svg-styles-manager.php +++ b/includes/class-fontawesome-svg-styles-manager.php @@ -110,9 +110,7 @@ public static function selfhost_asset_subdir( $version ) { * @internal */ public static function selfhost_asset_filename( $version ) { - return ( is_string( $version ) && strlen( $version ) > 0 && '7' === $version[0] ) - ? 'svg.css' - : 'svg-with-js.css'; + return 'svg-with-js.css'; } /** From 5c6763f8822eb7728fb7d63024d13ed2ecfa264f Mon Sep 17 00:00:00 2001 From: Mike Wilkerson <11575183+mlwilkerson@users.noreply.github.com> Date: Wed, 24 Sep 2025 12:18:33 -0700 Subject: [PATCH 2/2] remove unused $version param --- includes/class-fontawesome-svg-styles-manager.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/class-fontawesome-svg-styles-manager.php b/includes/class-fontawesome-svg-styles-manager.php index 691244594..9b209ef11 100644 --- a/includes/class-fontawesome-svg-styles-manager.php +++ b/includes/class-fontawesome-svg-styles-manager.php @@ -109,7 +109,7 @@ public static function selfhost_asset_subdir( $version ) { * @ignore * @internal */ - public static function selfhost_asset_filename( $version ) { + public static function selfhost_asset_filename() { return 'svg-with-js.css'; }