Cleanup (#1045)

* Update to Kotlin 2.3.20-RC3

* Add a convention plugin for KMP

* Add a jvm convention plugin

* Update Gradle to 9.4.0

* Update kctfork

* Clean up version catalog, consolidate versions, remove deprecated properties

- Rename `abg` to `agp`, remove duplicate `gradleMavenPublishPlugin` version
- Consolidate 8 ktorfit version entries to 3 (ktorfit, ktorfitCompiler, ktorfitGradlePlugin)
- Remove `groupId` from catalog, use `group` property in gradle.properties instead
- Add ktlint, gradlePluginPublish, licensee plugin entries to catalog
- Remove platform-specific ktor-client-core-* and ktor-client-cio-* catalog entries
- Replace platform-specific ktor deps with common artifacts in ktorfit-lib and sandbox
- Remove stale `kotlinx-serialization-runtime-js` usage from sandbox
- Remove deprecated `kotlin.native.binary.freezing` from root gradle.properties
- Remove deprecated `kotlin.mpp.androidSourceSetLayoutVersion=2` from module gradle.properties
- Add POM_ARTIFACT_ID to all module gradle.properties for vanniktech publishing
- Add `kotlin.js.yarn=false` to gradle.properties (Phase 10 prep)
- Update AGP to 9.0.0 and Detekt to 2.0.0-alpha.2 in catalog (Phases 4+8 prep)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Add publishing convention plugin and remove per-module publishing boilerplate

Create `ktorfit.publishing` convention plugin using vanniktech maven-publish
that handles publishToMavenCentral, signAllPublications, and all POM metadata
automatically from gradle.properties.

This removes from every module:
- `maven-publish` and `signing` plugin applications
- `enableSigning` conditional logic and sign task dependency workaround
- `javadocJar` task registration (vanniktech handles this)
- Entire `publishing { publications { ... } }` POM blocks (~30 lines each)
- Entire `publishing { repositories { ... } }` sonatype blocks (~15 lines each)

Each module now just applies `id("ktorfit.publishing")` and calls
`mavenPublishing { coordinates(version = ...) }`.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Add licensee convention plugin to deduplicate license config

Create `ktorfit.licensee` convention plugin that applies licensee and
configures Apache-2.0, MIT, and MIT URL allowances. Replace per-module
licensee blocks in all 8 published modules.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Remove buildscript block and clean up repository configuration

- Remove entire buildscript block from root build.gradle.kts (classpath deps
  now handled by build-logic convention plugins)
- Remove mavenLocal() from settings.gradle.kts and build-logic settings
- Remove duplicate google() repository
- Remove Ktor EAP and Kotlin WASM experimental repos (not needed)
- Remove resolutionStrategy for de.jensklingenberg.ktorfit plugin
- Move pluginManagement.dependencyResolutionManagement to top-level

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Migrate to AGP 9 KMP plugin and Detekt v2

AGP 9 migration:
- Replace `com.android.library` with `com.android.kotlin.multiplatform.library`
  in KMP convention plugin
- Move `androidTarget { publishLibraryVariants() }` to `androidLibrary {}`
- Remove standalone `android {}` blocks from all modules; move namespace
  into `kotlin { androidLibrary { namespace = "..." } }`
- Update compileSdk to 35, remove manual manifest srcFile setup
- Remove consumerProguardFiles from ktorfit-lib-core (not supported in
  AGP 9 KMP library plugin)

Detekt v2 migration:
- Update plugin ID from `io.gitlab.arturbosch.detekt` to `dev.detekt`
- Update Maven group from `io.gitlab.arturbosch.detekt` to `dev.detekt`
- Create `ktorfit.detekt` convention plugin with shared config
- Replace per-module detekt configuration blocks

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Switch from Yarn to npm for JS/WASM targets

- Set kotlin.js.yarn=false in gradle.properties (done in earlier commit)
- Remove kotlin-js-store/ directory containing yarn.lock files
- npm lock files will be generated on next build via kotlinUpgradePackageLock

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Move CI to ubuntu-latest and centralize Java version in .java-version

- Create .java-version file (JDK 25)
- Move build job from macos-latest to ubuntu-latest (klib cross-compilation)
- Move publish-annotations and publish-ktorfit-lib from macos-latest to ubuntu-latest
- Move publish-converters from macos-latest to ubuntu-latest
- Replace hardcoded java-version: 21 with java-version-file: .java-version
  across all workflow jobs
- Remove manual Gradle cache setup (gradle/actions/setup-gradle handles it)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Consolidate dependabot into renovate

- Remove .github/dependabot.yml (renovate handles gradle + github-actions)
- Remove update-gradle-wrapper.yml workflow (renovate handles wrapper updates)
- Update renovate.json5 with enabledManagers for gradle, gradle-wrapper,
  and github-actions; add registryUrls and dependency labels

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Remove unused catalog entries and add serialization plugin to root

- Remove unused `kotlin-serialization` library (was in removed buildscript block)
- Remove unused `ktorfit-gradle-plugin` library (sandbox uses project substitution)
- Add `kotlin("plugin.serialization")` to root plugins block so sandbox can
  resolve `id("kotlinx-serialization")` without buildscript classpath

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Fix build issues from modernization

- Change build-logic deps from compileOnly to implementation (required for
  precompiled script plugins to resolve plugin IDs at apply time)
- Re-add buildscript classpath for ktorfit-gradle-plugin (needed by sandbox)
- Re-add resolutionStrategy for de.jensklingenberg.ktorfit plugin in settings
- Update sandbox to use alias(libs.plugins.licensee) and alias(libs.plugins.ktorfit)
- Update detekt-config.yml for v2: rename ComplexMethod to
  CyclomaticComplexMethod, remove removed rules, fix excludedFunctions YAML format
- Regenerate detekt baselines for compiler-plugin and ksp modules
- Remove obsolete supportsK2 from compiler-plugin test (K2 is now default)
- Fix ktlint trailing blank line in compiler-plugin build file
- Regenerate klib API dumps (library unique name changed due to group property)
- Use released ktorfitGradlePlugin version (2.7.2) for buildscript resolution

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Add npm lock files after yarn-to-npm migration

Generated by the build after setting kotlin.js.yarn=false.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Use GROUP instead of group in gradle.properties to preserve klib API

The lowercase `group` property sets Gradle's project group, which changes
the klib library unique name (e.g. <Ktorfit:ktorfit-annotations> becomes
<de.jensklingenberg.ktorfit:ktorfit-annotations>). Use uppercase `GROUP`
instead, which the vanniktech maven-publish plugin reads for publishing
coordinates without affecting the project group.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Fix quick-win Kotlin warnings and add warnings plan doc

Suppress unnecessary safe call warnings on KSType in KSP code generators,
add @Suppress("UNCHECKED_CAST") for intentional generic casts, fix parameter
name mismatch in test, and remove deprecated developmentMode usage in sandbox.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Update AGP to 9.1.0

* Update maven publish plugin

* Cleanup gradle plugin module

* Update gradle plugin publish

* Add comment explaining the ktorfit versions in the catalog

* Update mockk

* Remove kapt

* Update releasing instructions

* Publish SNAPSHOT builds on pushes to master

* Fix more warnings

* Clean up sandbox build.gradle.kts

* Handle deprecated  API

* Update Gradle checksum

* Don't require signing when publishing to maven local

* Simplify running tasks on all modules in GitHub Actions

* Add test for #887

* Silence licensee unused license warning

* Don't apply kotlin(jvm) and kotlin-dsl plugins together

* Make detekt quieter when there are no violations

Author: eygraber

.github/dependabot.yml

@@ -21,7 +21,7 @@ on:
       - 'release/**'
 env:
   GRADLE_OPTS: "-Dorg.gradle.jvmargs=-Xmx8g -Dorg.gradle.daemon=false -Dkotlin.incremental=false"
-  
+
 jobs:
   set-milestone:
     if: github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository
@@ -56,7 +56,7 @@ jobs:
         uses: actions/setup-java@v5
         with:
           distribution: temurin
-          java-version: 21
+          java-version-file: .java-version
       - uses: gradle/actions/setup-gradle@v5
       - name: API check
         run: ./gradlew ktLintCheck
@@ -73,32 +73,34 @@ jobs:
         uses: actions/setup-java@v5
         with:
           distribution: temurin
-          java-version: 21
+          java-version-file: .java-version
       - uses: gradle/actions/setup-gradle@v5
       - name: API check
         run: ./gradlew apiCheck
       - name: 'Notify on failure'
         if: failure()
         run: echo "Format check failed. Run ./gradlew apiDump to fix."
   build:
-    runs-on: macos-latest
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v6
-      - name: Set up JDK 21
+      - name: Set up JDK
         uses: actions/setup-java@v5
         with:
-          java-version: 21
           distribution: 'temurin'
-      - name: Cache Gradle and wrapper
-        uses: actions/cache@v5
-        with:
-          path: |
-            ~/.gradle/caches
-            ~/.gradle/wrapper
-          key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*') }}
-          restore-keys: |
-            ${{ runner.os }}-gradle-    
-      - name: Grant execute permission for gradlew
-        run: chmod +x gradlew
+          java-version-file: .java-version
+      - uses: gradle/actions/setup-gradle@v5
       - name: Build and test with Gradle
-        run: ./gradlew licensee :ktorfit-gradle-plugin:publishToMavenLocal :ktorfit-annotations:publishToMavenLocal :ktorfit-ksp:publishToMavenLocal :ktorfit-lib-core:publishToMavenLocal :ktorfit-compiler-plugin:test :ktorfit-ksp:test :ktorfit-lib-core:jvmTest :ktorfit-converters:call:publishToMavenLocal :ktorfit-converters:flow:publishToMavenLocal :ktorfit-converters:response:publishToMavenLocal
+        run: ./gradlew build publishToMavenLocal
+  build-apple:
+    runs-on: macos-latest
+    steps:
+      - uses: actions/checkout@v6
+      - name: Set up JDK
+        uses: actions/setup-java@v5
+        with:
+          distribution: 'temurin'
+          java-version-file: .java-version
+      - uses: gradle/actions/setup-gradle@v5
+      - name: Build and test Apple targets
+        run: ./gradlew appleTest publishAppleToMavenLocal

.github/workflows/build.yml

@@ -5,16 +5,16 @@ on:
 
 jobs:
   publish-converters:
-    runs-on: macos-latest
+    runs-on: ubuntu-latest
     steps:
       - name: Checkout
         uses: actions/checkout@v6
 
-      - name: Install JDK 21
+      - name: Set up JDK
         uses: actions/setup-java@v5
         with:
           distribution: 'temurin'
-          java-version: 21
+          java-version-file: .java-version
 
       - uses: gradle/actions/setup-gradle@v5
       - name: Publish release

.github/workflows/publish-converters.yml

@@ -9,15 +9,15 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v6
-      - name: Set up JDK 21
+      - name: Set up JDK
         uses: actions/setup-java@v5
         with:
           distribution: 'temurin'
-          java-version: 21
+          java-version-file: .java-version
       - name: Set up Gradle
         uses: gradle/actions/setup-gradle@v5
       - name: Publish plugin
         env:
           GRADLE_PUBLISH_KEY: ${{ secrets.GRADLE_PUBLISH_KEY }}
           GRADLE_PUBLISH_SECRET: ${{ secrets.GRADLE_PUBLISH_SECRET }}
-        run: ./gradlew :ktorfit-gradle-plugin:publishPlugins -Dgradle.publish.key=${GRADLE_PUBLISH_KEY} -Dgradle.publish.secret=${GRADLE_PUBLISH_SECRET}
+        run: ./gradlew :ktorfit-gradle-plugin:publishPlugins -Dgradle.publish.key=${GRADLE_PUBLISH_KEY} -Dgradle.publish.secret=${GRADLE_PUBLISH_SECRET}

.github/workflows/publish-gradle-plugin.yml

@@ -0,0 +1,45 @@
+name: Publish Snapshot
+
+on:
+  push:
+    branches:
+      - master
+
+jobs:
+  publish-snapshot:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v6
+
+      - name: Set up JDK
+        uses: actions/setup-java@v5
+        with:
+          distribution: 'temurin'
+          java-version-file: .java-version
+
+      - uses: gradle/actions/setup-gradle@v5
+
+      - name: Bump versions to SNAPSHOT
+        run: |
+          bump_snapshot() {
+            local key="$1"
+            local version
+            version=$(grep "^${key} = " gradle/libs.versions.toml | sed 's/.*"\(.*\)"/\1/')
+            local major minor patch
+            IFS='.' read -r major minor patch <<< "$version"
+            patch=$((patch + 1))
+            local snapshot="${major}.${minor}.${patch}-SNAPSHOT"
+            sed -i "s/^${key} = \".*\"/${key} = \"${snapshot}\"/" gradle/libs.versions.toml
+            echo "${key}: ${version} -> ${snapshot}"
+          }
+          bump_snapshot "ktorfit"
+          bump_snapshot "ktorfitCompiler"
+
+      - name: Publish snapshot
+        run: ./gradlew publishToMavenCentral
+        env:
+          ORG_GRADLE_PROJECT_mavenCentralUsername: ${{ secrets.SONATYPE_NEXUS_USERNAME }}
+          ORG_GRADLE_PROJECT_mavenCentralPassword: ${{ secrets.SONATYPE_NEXUS_PASSWORD }}
+          ORG_GRADLE_PROJECT_signingInMemoryKey: ${{ secrets.SIGNING_IN_MEMORY }}
+          ORG_GRADLE_PROJECT_signingInMemoryKeyPassword: ${{ secrets.SIGNING_PASSWORD }}

.github/workflows/publish-snapshot.yml

@@ -5,16 +5,16 @@ on:
 
 jobs:
   publish-annotations:
-    runs-on: macos-latest
+    runs-on: ubuntu-latest
     steps:
       - name: Checkout
         uses: actions/checkout@v6
 
-      - name: Install JDK 21
+      - name: Set up JDK
         uses: actions/setup-java@v5
         with:
           distribution: 'temurin'
-          java-version: 21
+          java-version-file: .java-version
 
       - uses: gradle/actions/setup-gradle@v5
 
@@ -31,11 +31,11 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v6
 
-      - name: Install JDK 21
+      - name: Set up JDK
         uses: actions/setup-java@v5
         with:
           distribution: 'temurin'
-          java-version: 21
+          java-version-file: .java-version
 
       - uses: gradle/actions/setup-gradle@v5
 
@@ -52,11 +52,11 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v6
 
-      - name: Install JDK 21
+      - name: Set up JDK
         uses: actions/setup-java@v5
         with:
           distribution: 'temurin'
-          java-version: 21
+          java-version-file: .java-version
 
       - uses: gradle/actions/setup-gradle@v5
 
@@ -73,11 +73,11 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v6
 
-      - name: Install JDK 21
+      - name: Set up JDK
         uses: actions/setup-java@v5
         with:
           distribution: 'temurin'
-          java-version: 21
+          java-version-file: .java-version
 
       - uses: gradle/actions/setup-gradle@v5
 
@@ -89,16 +89,16 @@ jobs:
           ORG_GRADLE_PROJECT_signingInMemoryKey: ${{ secrets.SIGNING_IN_MEMORY }}
           ORG_GRADLE_PROJECT_signingInMemoryKeyPassword: ${{ secrets.SIGNING_PASSWORD }}
   publish-ktorfit-lib:
-    runs-on: macos-latest
+    runs-on: ubuntu-latest
     steps:
       - name: Checkout
         uses: actions/checkout@v6
 
-      - name: Install JDK 21
+      - name: Set up JDK
         uses: actions/setup-java@v5
         with:
           distribution: 'temurin'
-          java-version: 21
+          java-version-file: .java-version
 
       - uses: gradle/actions/setup-gradle@v5
 

.github/workflows/publish.yml

@@ -0,0 +1 @@
+25

.github/workflows/update-gradle-wrapper.yml

@@ -4,18 +4,16 @@ Releasing
 # Publish new version
 
 1. Create new branch `release/X.Y.Z` from `master` branch
-2. Update **ktorfit** version inside `gradle/libs.versions.toml`
-3. Update **ktorfitGradlePlugin** version inside `gradle/libs.versions.toml`
-4. Update Compatibility table in Readme.md
-5. Update KtorfitCompilerSubPlugin.defaultCompilerPluginVersion if necessary 
-6. Update ktorfit release version in mkdocs.yml
-7. Update version in KtorfitGradleConfiguration
-8. Set the release date in docs/changelog.md
-9. `git commit -am "X.Y.Z."` (where X.Y.Z is the new version)
-10. Push and create a PR to the `master` branch
-11. When all checks successful, run GitHub Action `Publish Release` from your branch
-12. Set the Git tag `git tag -a X.Y.Z -m "X.Y.Z"` (where X.Y.Z is the new version)
-13. Merge the PR
-14. Create a new release with for the Tag on GitHub
-15. Run "deploy to GitHub pages" action
-16. Put the relevant changelog in the release description
+2. Update **ktorfit** and **ktorfitCompiler** version inside `gradle/libs.versions.toml`
+3. Update Compatibility table in Readme.md
+4. Update KtorfitCompilerSubPlugin.defaultCompilerPluginVersion if necessary 
+5. Update ktorfit release version in mkdocs.yml
+6. Set the release date in docs/changelog.md
+7. `git commit -am "X.Y.Z."` (where X.Y.Z is the new version)
+8. Push and create a PR to the `master` branch
+9. When all checks successful, run GitHub Action `Publish Release` from your branch
+10. Set the Git tag `git tag -a X.Y.Z -m "X.Y.Z"` (where X.Y.Z is the new version)
+11. Merge the PR
+12. Create a new release with for the Tag on GitHub
+13. Run "deploy to GitHub pages" action
+14. Put the relevant changelog in the release description

.java-version

@@ -0,0 +1,11 @@
+plugins {
+    `kotlin-dsl`
+}
+
+dependencies {
+    implementation(libs.android.build.gradle)
+    implementation(libs.kotlin.gradle.plugin)
+    implementation(libs.gradle.maven.publish.plugin)
+    implementation(libs.licensee.gradle.plugin)
+    implementation(libs.detekt.gradle.plugin)
+}