Skip to content

Commit fb7894a

Browse files
authored
Merge pull request #43 from FoundatioFx/systemclock
Adapt to system clock changes
2 parents c33252d + 40e16c5 commit fb7894a

File tree

5 files changed

+10
-11
lines changed

5 files changed

+10
-11
lines changed

src/Foundatio.AzureServiceBus/Foundatio.AzureServiceBus.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<PackageReference Include="Microsoft.Azure.Management.ServiceBus" Version="5.0.0" />
55
<PackageReference Include="Microsoft.Azure.ServiceBus" Version="5.2.0" />
66

7-
<PackageReference Include="Foundatio" Version="10.7.1" Condition="'$(ReferenceFoundatioSource)' == '' OR '$(ReferenceFoundatioSource)' == 'false'" />
7+
<PackageReference Include="Foundatio" Version="11.0.0" Condition="'$(ReferenceFoundatioSource)' == '' OR '$(ReferenceFoundatioSource)' == 'false'" />
88

99
<!-- NOTE: Forcing minimum for security patch. Remove once SDK versions are updated -->
1010
<PackageReference Include="Microsoft.Rest.ClientRuntime" Condition="" Version="2.3.24" />

src/Foundatio.AzureServiceBus/Messaging/AzureServiceBusMessageBus.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
using Foundatio.AsyncEx;
66
using Foundatio.Extensions;
77
using Foundatio.Serializer;
8-
using Foundatio.Utility;
98
using Microsoft.Azure.ServiceBus;
109
using Microsoft.Azure.ServiceBus.Management;
1110
using Microsoft.Extensions.Logging;
@@ -133,7 +132,7 @@ protected override Task PublishImplAsync(string messageType, object message, Mes
133132
if (options.DeliveryDelay.HasValue && options.DeliveryDelay.Value > TimeSpan.Zero)
134133
{
135134
_logger.LogTrace("Schedule delayed message: {messageType} ({delay}ms)", messageType, options.DeliveryDelay.Value.TotalMilliseconds);
136-
brokeredMessage.ScheduledEnqueueTimeUtc = SystemClock.UtcNow.Add(options.DeliveryDelay.Value);
135+
brokeredMessage.ScheduledEnqueueTimeUtc = _timeProvider.GetUtcNow().UtcDateTime.Add(options.DeliveryDelay.Value);
137136
}
138137
else
139138
{

src/Foundatio.AzureServiceBus/Queues/AzureServiceBusQueue.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
using Foundatio.AzureServiceBus.Queues;
99
using Foundatio.Extensions;
1010
using Foundatio.Serializer;
11-
using Foundatio.Utility;
1211
using Microsoft.Azure.ServiceBus;
1312
using Microsoft.Azure.ServiceBus.Core;
1413
using Microsoft.Azure.ServiceBus.Management;
@@ -147,7 +146,7 @@ protected override async Task<string> EnqueueImplAsync(T data, QueueEntryOptions
147146

148147
await _queueSender.SendAsync(brokeredMessage).AnyContext();
149148

150-
var entry = new QueueEntry<T>(brokeredMessage.MessageId, brokeredMessage.CorrelationId, data, this, SystemClock.UtcNow, 0);
149+
var entry = new QueueEntry<T>(brokeredMessage.MessageId, brokeredMessage.CorrelationId, data, this, _timeProvider.GetUtcNow().UtcDateTime, 0);
151150
entry.SetLockToken(brokeredMessage);
152151
foreach (var property in brokeredMessage.UserProperties)
153152
entry.Properties.Add(property.Key, property.Value.ToString());

tests/Directory.Build.props

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,13 @@
66
<NoWarn>$(NoWarn);CS1591;NU1701</NoWarn>
77
</PropertyGroup>
88
<ItemGroup>
9-
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
10-
<PackageReference Include="xunit" Version="2.7.0" />
11-
<PackageReference Include="xunit.runner.visualstudio" Version="2.5.7" />
9+
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.0" />
10+
<PackageReference Include="xunit" Version="2.9.0" />
11+
<PackageReference Include="xunit.runner.visualstudio" Version="2.8.2" />
1212

13-
<PackageReference Include="GitHubActionsTestLogger" Version="2.3.3" PrivateAssets="All" />
13+
<PackageReference Include="GitHubActionsTestLogger" Version="2.4.1" PrivateAssets="All" />
1414

15-
<PackageReference Include="Foundatio.TestHarness" Version="10.7.1" Condition="'$(ReferenceFoundatioSource)' == '' OR '$(ReferenceFoundatioSource)' == 'false'" />
15+
<PackageReference Include="Foundatio.TestHarness" Version="11.0.0" Condition="'$(ReferenceFoundatioSource)' == '' OR '$(ReferenceFoundatioSource)' == 'false'" />
1616
<ProjectReference Include="..\..\..\Foundatio\src\Foundatio.TestHarness\Foundatio.TestHarness.csproj" Condition="'$(ReferenceFoundatioSource)' == 'true'" />
1717
</ItemGroup>
1818
</Project>

tests/Foundatio.AzureServiceBus.Tests/Queues/AzureServiceBusQueueTests.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ public AzureServiceBusQueueTests(ITestOutputHelper output) : base(output)
1919
Log.SetLogLevel<AzureServiceBusQueue<SimpleWorkItem>>(LogLevel.Trace);
2020
}
2121

22-
protected override IQueue<SimpleWorkItem> GetQueue(int retries = 1, TimeSpan? workItemTimeout = null, TimeSpan? retryDelay = null, int[] retryMultipliers = null, int deadLetterMaxItems = 100, bool runQueueMaintenance = true)
22+
protected override IQueue<SimpleWorkItem> GetQueue(int retries = 1, TimeSpan? workItemTimeout = null, TimeSpan? retryDelay = null, int[] retryMultipliers = null, int deadLetterMaxItems = 100, bool runQueueMaintenance = true, TimeProvider timeProvider = null)
2323
{
2424
string connectionString = Configuration.GetConnectionString("AzureServiceBusConnectionString");
2525
if (String.IsNullOrEmpty(connectionString))
@@ -44,6 +44,7 @@ protected override IQueue<SimpleWorkItem> GetQueue(int retries = 1, TimeSpan? wo
4444
RequiresSession = false,
4545
Retries = retries,
4646
RetryPolicy = retryPolicy,
47+
TimeProvider = timeProvider,
4748
WorkItemTimeout = workItemTimeout.GetValueOrDefault(TimeSpan.FromMinutes(5)),
4849
LoggerFactory = Log
4950
});

0 commit comments

Comments
 (0)