calcN! optimization

[navidcy]

@glwagner any ideas to better optimize calcN!?

Brusselator.jl/src/Brusselator.jl

Lines 93 to 110 in 903fbbe

	function calcN!(N, sol, t, clock, vars, params, grid)
	@. vars.uh = sol[:, 1]
	@. vars.vh = sol[:, 2]
	ldiv!(vars.u, grid.rfftplan, vars.uh)
	ldiv!(vars.v, grid.rfftplan, vars.vh)
	@. vars.vu² = vars.v * vars.u^2
	mul!(vars.vu²h, grid.rfftplan, vars.vu²)
	@views @. N[:, 1] = + vars.vu²h - (params.B + 1) * sol[:, 1] # + v*u² - (B+1) u
	N[1, 1] += params.E * grid.nx # note that fft(constant) = constant * nx
	@views @. N[:, 2] = - vars.vu²h + params.B * sol[:, 1] # - v*u² + B*u
	return nothing
	end

[glwagner]

line 105 could use @inbounds. Not sure what else...

[navidcy]

what about @Inbouds on line 107?

[glwagner]

@inbounds is implied by broadcasting, I think.

[rveltz]

@. vars.uh = @view sol[:, 1] ?