Skip to content

Commit a81654a

Browse files
committed
Update README and toastr-config
1 parent 0e8d2a6 commit a81654a

File tree

6 files changed

+15
-9
lines changed

6 files changed

+15
-9
lines changed

README.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,7 @@ app.config(function(toastrConfig) {
124124
onShown: null,
125125
positionClass: 'toast-top-right',
126126
tapToDismiss: true,
127+
target: 'body',
127128
timeOut: 5000,
128129
titleClass: 'toast-title',
129130
toastClass: 'toast'
@@ -146,6 +147,7 @@ Those are the default values, you can pick what you need from it and override wi
146147
* **onShown**: A callback function called when a toast is shown.
147148
* **positionClass**: The position where the toasts are added.
148149
* **tapToDismiss**: Whether the toast should be dismissed when it is clicked.
150+
* **target**: The element to put the toastr container.
149151
* **timeOut**: The timeout before the toasts disappear.
150152
* **titleClass**: The class for the toast's title.
151153
* **toastClass**: Base class for toasts.
@@ -271,10 +273,14 @@ $ testem -f config/testem.json
271273

272274
Then you can see if you have your new tests pass.
273275

276+
Try to avoid generating the `/dist` files on a patch because sometimes they don't want to merge nicely and it is a pain to merge by hand.
277+
278+
----------
279+
274280
## Credits
275281

276282
All the credits for the guys at [CodeSeven/toastr](https://github.com/CodeSeven/toastr) for creating the original implementation.
277283

278284
## License
279285

280-
Mit License: [http://www.opensource.org/licenses/mit-license.php](http://www.opensource.org/licenses/mit-license.php)
286+
Mit License: [http://www.opensource.org/licenses/mit-license.php](http://www.opensource.org/licenses/mit-license.php)

dist/angular-toastr.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -237,10 +237,10 @@
237237
onShown: null,
238238
positionClass: 'toast-top-right',
239239
tapToDismiss: true,
240+
target: 'body',
240241
timeOut: 5000,
241242
titleClass: 'toast-title',
242-
toastClass: 'toast',
243-
target: 'body'
243+
toastClass: 'toast'
244244
});
245245
}());
246246

dist/angular-toastr.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/angular-toastr.tpls.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -237,10 +237,10 @@
237237
onShown: null,
238238
positionClass: 'toast-top-right',
239239
tapToDismiss: true,
240+
target: 'body',
240241
timeOut: 5000,
241242
titleClass: 'toast-title',
242-
toastClass: 'toast',
243-
target: 'body'
243+
toastClass: 'toast'
244244
});
245245
}());
246246

dist/angular-toastr.tpls.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/toastr-config.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@
1919
onShown: null,
2020
positionClass: 'toast-top-right',
2121
tapToDismiss: true,
22+
target: 'body',
2223
timeOut: 5000,
2324
titleClass: 'toast-title',
24-
toastClass: 'toast',
25-
target: 'body'
25+
toastClass: 'toast'
2626
});
2727
}());

0 commit comments

Comments
 (0)