Refactor model classes and fix property assignments

Aligned variable declarations for consistency in Arma3Profile and BasicCfg. Removed unused properties and redundant event handling from ServerCfg. Ensured AdvancedOptions and its content are properly initialized in ServerProfile constructors.

Author: jupster

FASTER/Models/Arma3Profile.cs

@@ -41,7 +41,7 @@ public class Arma3Profile : INotifyPropertyChanged
         private ushort mapContentMines    = 1;
         private ushort autoReport         = 0;
         private ushort multipleSaves      = 0;
-        private int tacticalPing          = 1;
+        private int    tacticalPing       = 1;
 
         private ushort aiLevelPreset      = 3;
         private double skillAi            = 0.5;

FASTER/Models/BasicCfg.cs

@@ -14,8 +14,8 @@ public static class BasicCfgArrays
     [Serializable]
     public class BasicCfg : INotifyPropertyChanged
     {
-        private uint   viewDistance = 2000;
-        private double terrainGrid  = 25;
+        private uint   viewDistance         = 2000;
+        private double terrainGrid          = 25;
 
         private ushort maxMsgSend           = 128;
         private ushort maxSizeGuaranteed    = 256;
@@ -158,10 +158,10 @@ public string PerfPreset
                 MaxMsgSend           = 256;
                 MaxSizeGuaranteed    = 512;
                 MaxSizeNonGuaranteed = 256;
-                MinErrorToSend     = 0.001;
-                MinErrorToSendNear = 0.01;
-                MaxPacketSize      = 1400;
-                MaxCustomFileSize  = 160;
+                MinErrorToSend       = 0.001;
+                MinErrorToSendNear   = 0.01;
+                MaxPacketSize        = 1400;
+                MaxCustomFileSize    = 160;
 
 
                 switch ((short)Array.IndexOf(BasicCfgArrays.PerfPresets, value))
@@ -177,8 +177,8 @@ public string PerfPreset
                         MinBandwidth = 250000000;
                         break;
                     case 4:
-                        MaxMsgSend           = 512;
-                        MinBandwidth         = 1000000000;
+                        MaxMsgSend   = 512;
+                        MinBandwidth = 1000000000;
                         break;
                 }
                 RaisePropertyChanged("PerfPreset");

FASTER/Models/ServerCfg.cs

@@ -771,11 +771,6 @@ public ServerCfg()
             { ServerCfgContent = ProcessFile(); }
         }
 
-        public object LogObjectNotFound { get; private set; }
-        public object SkipDescriptionParsing { get; private set; }
-        public object IgnoreMissionLoadErrors { get; private set; }
-        public object QueueSizeLogG { get; private set; }
-
     [Serializable]
     public class AdvancedOptions : INotifyPropertyChanged
     {
@@ -824,7 +819,7 @@ public int QueueSizeLogG
             }
         }
 
-		private string advancedOptionsContent;    
+		private string advancedOptionsContent;
 
         public string AdvancedOptionsContent
         {
@@ -842,16 +837,6 @@ public AdvancedOptions()
             { AdvancedOptionsContent = ProcessFile(); }
         }
 
-        public event PropertyChangedEventHandler PropertyChanged;
-
-        private void RaisePropertyChanged(string property)
-        {
-            if (PropertyChanged == null) return;
-            PropertyChanged(this, new PropertyChangedEventArgs(property));
-			if(property != "AdvancedOptionsContent") AdvancedOptionsContent = ProcessFile();
-        }
-	}
-	
         private void Item_PropertyChanged(object sender, PropertyChangedEventArgs e)
         {
             RaisePropertyChanged("MissionChecked");
@@ -1025,4 +1010,5 @@ private void RaisePropertyChanged(string property)
             PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(property));
         }
     }
+  }
 }

FASTER/Models/ServerProfile.cs

@@ -428,12 +428,14 @@ public ServerProfile(string name, bool createFolder = true)
             Name = name;
             Executable = Path.Combine(Properties.Settings.Default.serverPath, "arma3server_x64.exe");
             ServerCfg = new ServerCfg(){ Hostname = name};
+            AdvancedOptions = new AdvancedOptions();
             ArmaProfile = new Arma3Profile();
             BasicCfg = new BasicCfg();
             ServerCfg.ServerCfgContent = ServerCfg.ProcessFile();
+			ServerCfg.AdvancedOptionsContent = AdvancedOptions.ProcessFile();
             ArmaProfile.ArmaProfileContent = ArmaProfile.ProcessFile();
             BasicCfg.BasicContent = BasicCfg.ProcessFile();
-
+            ServerCfg.AdvancedOptionsContent = AdvancedOptions.ProcessFile();
             if (createFolder)
             { Directory.CreateDirectory(Path.Combine(Properties.Settings.Default.serverPath, "Servers", Id)); }
         }
@@ -446,6 +448,7 @@ public ServerProfile()
             ArmaProfile = new Arma3Profile();
             BasicCfg    = new BasicCfg();
             ServerCfg.ServerCfgContent = ServerCfg.ProcessFile();
+            ServerCfg.AdvancedOptionsContent = AdvancedOptions.ProcessFile();		
             ArmaProfile.ArmaProfileContent = ArmaProfile.ProcessFile();
             BasicCfg.BasicContent = BasicCfg.ProcessFile();
         }