Commit 8e4dcb1
committed
.github/workflows/os-check.yml: address review nits on the split refactor
- Drop the section dividers in make_check_linux's config list. The two
groups they marked were "old make_check configs" vs "old
make_check_linux configs" -- an artifact of the merge, not a real
semantic distinction (e.g. SHE / harden-tls / sniffer entries have no
Darwin paths to be "covered by make_check_macos" at all). Replaced
with a single "Add new configs here" comment.
- Drop the parens from job display names: "make check (Linux)" /
"make check (macOS)" rendered as "make check (Linux) (<config>)" in
the GitHub UI under a 1-D matrix. Now "make check linux" /
"make check macos".
- Tighten the --disable-sys-ca-certs comment in make_check_macos. The
meaningful signal is the configure-time auto-enable override and the
Security.framework code path being compiled out cleanly; the runtime
test on the resulting binary doesn't differ much from Linux.
- Drop the dead-weight single-element os: [ ubuntu-24.04 ] matrix axis
on make_user_settings_testwolfcrypt, matching the same cleanup
already done on make_user_settings and make_user_all.1 parent fbd65a7 commit 8e4dcb1
1 file changed
Lines changed: 9 additions & 15 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
| 24 | + | |
28 | 25 | | |
29 | 26 | | |
30 | 27 | | |
| |||
91 | 88 | | |
92 | 89 | | |
93 | 90 | | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | 91 | | |
98 | 92 | | |
99 | 93 | | |
| |||
115 | 109 | | |
116 | 110 | | |
117 | 111 | | |
118 | | - | |
| 112 | + | |
119 | 113 | | |
120 | 114 | | |
121 | 115 | | |
| |||
144 | 138 | | |
145 | 139 | | |
146 | 140 | | |
147 | | - | |
148 | | - | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
149 | 144 | | |
150 | 145 | | |
151 | 146 | | |
| |||
158 | 153 | | |
159 | 154 | | |
160 | 155 | | |
161 | | - | |
| 156 | + | |
162 | 157 | | |
163 | 158 | | |
164 | 159 | | |
| |||
198 | 193 | | |
199 | 194 | | |
200 | 195 | | |
| 196 | + | |
| 197 | + | |
201 | 198 | | |
202 | 199 | | |
203 | 200 | | |
204 | | - | |
205 | | - | |
206 | | - | |
207 | 201 | | |
208 | 202 | | |
209 | 203 | | |
| |||
227 | 221 | | |
228 | 222 | | |
229 | 223 | | |
230 | | - | |
| 224 | + | |
231 | 225 | | |
232 | 226 | | |
233 | 227 | | |
| |||
0 commit comments