Fix some you-dont-need-lodash-underscore issues

Author: davidmz

app/controllers/api/v1/GroupsController.js

@@ -58,7 +58,7 @@ export default class GroupsController {
       'isRestricted',
     ]);
 
-    if (!_.isArray(ctx.request.body.admins)) {
+    if (!Array.isArray(ctx.request.body.admins)) {
       throw new BadRequestException('"admins" should be an array of strings');
     }
 

app/controllers/api/v2/EventsController.js

@@ -101,7 +101,7 @@ function getQueryParams(ctx) {
   const limit = parseInt(ctx.request.query.limit, 10) || DEFAULT_EVENTS_LIMIT;
   let eventGroups = ctx.request.query.filter || [];
 
-  if (!_.isArray(eventGroups)) {
+  if (!Array.isArray(eventGroups)) {
     eventGroups = [eventGroups];
   }
 

app/pubsub-listener.js

@@ -2,7 +2,6 @@ import Redis from 'ioredis';
 import {
   cloneDeep,
   intersection,
-  isArray,
   isFunction,
   isPlainObject,
   keyBy,
@@ -135,7 +134,7 @@ export default class PubsubListener {
       }
 
       const channelListsPromises = map(data, async (channelIds, channelType) => {
-        if (!isArray(channelIds)) {
+        if (!Array.isArray(channelIds)) {
           throw new EventHandlingError(`List of ${channelType} ids has to be an array`);
         }
 
@@ -193,7 +192,7 @@ export default class PubsubListener {
       for (const channelType of Object.keys(data)) {
         const channelIds = data[channelType];
 
-        if (!isArray(channelIds)) {
+        if (!Array.isArray(channelIds)) {
           throw new EventHandlingError(
             `List of ${channelType} ids has to be an array`,
             `got bogus channel list`,

eslint.config.js

@@ -116,9 +116,10 @@ export default defineConfig([
       'you-dont-need-lodash-underscore/find': 'error',
       'you-dont-need-lodash-underscore/find-index': 'error',
       'you-dont-need-lodash-underscore/includes': 'error',
+      'you-dont-need-lodash-underscore/uniq': 'off',
       'lodash/prefer-lodash-method': 'off',
       'lodash/prefer-lodash-typecheck': 'off',
-      'lodash/import-scope': ['warn', 'member'],
+      'lodash/import-scope': 'off', // TODO set to `['warn', 'member']`
       'lodash/prefer-constant': 'off',
       'lodash/prefer-noop': 'off',
       'lodash/prefer-lodash-chain': 'off',

test/functional/functional_test_helper.js

@@ -6,7 +6,6 @@ import { readFile } from 'fs/promises';
 import { basename } from 'path';
 
 import request from 'superagent';
-// eslint-disable-next-line lodash/import-scope
 import _, { merge } from 'lodash-es';
 import socketIO from 'socket.io-client';
 import expect from 'unexpected';

test/functional/privates.js

@@ -2,7 +2,6 @@
 /* eslint-disable @typescript-eslint/no-unused-expressions */
 /* global $pg_database */
 import request from 'superagent';
-// eslint-disable-next-line lodash/import-scope
 import * as _ from 'lodash-es';
 import expect from 'unexpected';