Don't count still images in audio files as a video streams

Author: davidmz

app/support/media-files/detect.ts

@@ -2,7 +2,14 @@ import { open } from 'fs/promises';
 
 import { spawnAsync } from '../spawn-async';
 
-import { AvcStream, FfprobeResult, H264Info, MediaInfo, MediaInfoVideo } from './types';
+import {
+  AvcStream,
+  FfprobeResult,
+  H264Info,
+  MediaInfo,
+  MediaInfoVideo,
+  VideoStream,
+} from './types';
 import { addFileExtension } from './file-ext';
 
 export async function detectMediaType(
@@ -64,7 +71,13 @@ export async function detectMediaType(
     const { format, streams } = await runFfprobe(localFilePath);
     const fmt = format.format_name.split(',')[0].toLowerCase();
 
-    const videoStream = streams.find((s) => s.codec_type === 'video');
+    const videoStream = streams.find(
+      (s) =>
+        s.codec_type === 'video' &&
+        // And not an album cover or other static image
+        s.disposition.attached_pic !== 1 &&
+        s.disposition.still_image !== 1,
+    ) as VideoStream | undefined;
     const audioStream = streams.find((s) => s.codec_type === 'audio');
 
     if (videoStream && format.duration) {

app/support/media-files/types.ts

@@ -88,21 +88,30 @@ export type FilesToUpload = { [variant: string]: { path: string; ext: string } }
 export type VisualPreviews = { [variant: string]: { w: number; h: number; ext: string } };
 export type NonVisualPreviews = { [variant: string]: { ext: string } };
 
-export type Stream = { codec_name: string } & (
-  | {
-      codec_type: 'video';
-      width: number;
-      height: number;
-      nb_frames: string;
-      side_data_list?: Record<string, string | number>[];
-      is_avc?: 'true' | 'false';
-    }
-  | {
-      codec_type: 'audio';
-    }
-);
-
-export type AvcStream = Stream & {
+type CommonStream = {
+  codec_name: string;
+  disposition: {
+    attached_pic: 1 | 0;
+    still_image: 1 | 0;
+  };
+};
+
+export type VideoStream = CommonStream & {
+  codec_type: 'video';
+  width: number;
+  height: number;
+  nb_frames: string;
+  side_data_list?: Record<string, string | number>[];
+  is_avc?: 'true' | 'false';
+};
+
+export type AudioStream = CommonStream & {
+  codec_type: 'audio';
+};
+
+export type Stream = VideoStream | AudioStream;
+
+export type AvcStream = VideoStream & {
   is_avc: 'true';
   profile: string;
   level: number;