Add error logging to the Attachment model

Author: davidmz

app/models/attachment.js

@@ -20,6 +20,7 @@ import { TooManyRequestsException } from '../support/exceptions';
 const mvAsync = util.promisify(mv);
 
 const debug = createDebug('freefeed:model:attachment');
+const debugError = createDebug('freefeed:model:attachment:error');
 
 export function addModel(dbAdapter) {
   return class Attachment {
@@ -99,7 +100,10 @@ export function addModel(dbAdapter) {
           };
 
           if (!entry.url) {
-            debug(`no URL for image size ${variant} of attachment ${this.id}`, this._imageSizes);
+            debugError(
+              `no URL for image size ${variant} of attachment ${this.id}`,
+              this._imageSizes,
+            );
           }
         }
       }
@@ -148,7 +152,7 @@ export function addModel(dbAdapter) {
 
         if (inProgressMedia >= limit) {
           // User has too many media in progress, don't process any more
-          debug(
+          debugError(
             `user ${user.id} has too many attachments in progress, aborting the ${filePath} processing`,
           );
           await Promise.all(Object.values(files).map((file) => fs.unlink(file.path)));
@@ -211,7 +215,7 @@ export function addModel(dbAdapter) {
         });
 
         if (!files['']) {
-          debug(`no original file to upload (${this.id})`);
+          debugError(`no original file to upload (${this.id})`);
           throw new Error('No original file to upload');
         }
 
@@ -224,7 +228,7 @@ export function addModel(dbAdapter) {
         // Update data
         await dbAdapter.updateAttachment(this.id, { ...mediaData, updatedAt: 'now' });
       } catch (err) {
-        debug(`finalizeCreation error: ${err.message}, treat file as 'general' type`);
+        debugError(`finalizeCreation error: ${err.message}, treat file as 'general' type`);
 
         const { size: fileSize } = await fs.stat(filePath);
         const ext = extname(this.fileName)
@@ -488,7 +492,7 @@ export function addModel(dbAdapter) {
         } catch (err) {
           // Exiftool is failed, so the file was not updated and we cannot do
           // anymore here
-          debug(`sanitizeOriginal: cannot sanitize attachment ${this.id}: ${err.message}`);
+          debugError(`sanitizeOriginal: cannot sanitize attachment ${this.id}: ${err.message}`);
           Raven.captureException(err, {
             extra: {
               err: `sanitizeOriginal: cannot sanitize attachment ${this.id}`,
@@ -540,7 +544,7 @@ export function addModel(dbAdapter) {
           await fs.unlink(localFile);
         } catch (err) {
           if (err.code !== 'ENOENT') {
-            debug(`sanitizeOriginal: cannot remove temporary file: ${localFile}`);
+            debugError(`sanitizeOriginal: cannot remove temporary file: ${localFile}`);
             Raven.captureException(err, {
               extra: { err: `sanitizeOriginal: cannot remove temporary file: ${localFile}` },
             });

package.json

@@ -3,7 +3,7 @@
   "name": "freefeed-server",
   "description": "FreeFeed is an open source FriendFeed clone (yes, it is free and open!) based on Pepyatka open-source FriendFeed clone (yes, that one is also free and open). Basically, this is a social real-time feed aggregator that allows you to share cute kittens, coordinate upcoming events, discuss any other cool stuff on the Internet or setup a private Pepyatka instance in your company.",
   "homepage": "https://freefeed.net",
-  "version": "2.23.3",
+  "version": "2.23.4",
   "private": true,
   "scripts": {
     "start": "cross-env TZ=UTC yarn babel index.js",