odbc: Write a test for SQL_COPT_SS_OLDPWD option

Create a login with an expiring password, check we can
login and change the password at the same time.

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>

Author: freddy77

src/odbc/unittests/CMakeLists.txt

@@ -33,6 +33,7 @@ set(tests
 	tvp tokens
 	describeparam
 	reexec
+	oldpwd
 )
 
 if(WIN32)

src/odbc/unittests/Makefile.am

@@ -86,9 +86,10 @@ TESTS =	\
 	tokens$(EXEEXT) \
 	describeparam$(EXEEXT) \
 	reexec$(EXEEXT) \
+	oldpwd$(EXEEXT) \
 	$(NULL)
 
-check_PROGRAMS	=	$(TESTS) oldpwd$(EXEEXT)
+check_PROGRAMS	=	$(TESTS)
 
 t0001_SOURCES	=	t0001.c
 t0002_SOURCES	=	t0002.c

src/odbc/unittests/common.c

@@ -638,7 +638,10 @@ odbc_read_error(void)
 
 	memset(odbc_err, 0, sizeof(odbc_err));
 	memset(odbc_sqlstate, 0, sizeof(odbc_sqlstate));
-	CHKGetDiagRec(SQL_HANDLE_STMT, odbc_stmt, 1, state, NULL, err, sizeof(odbc_err), NULL, "SI");
+	if (odbc_stmt != SQL_NULL_HSTMT)
+		CHKGetDiagRec(SQL_HANDLE_STMT, odbc_stmt, 1, state, NULL, err, sizeof(odbc_err), NULL, "SI");
+	else
+		CHKGetDiagRec(SQL_HANDLE_DBC, odbc_conn, 1, state, NULL, err, sizeof(odbc_err), NULL, "SI");
 	strcpy(odbc_err, C(err));
 	strcpy(odbc_sqlstate, C(state));
 	ODBC_FREE();

src/odbc/unittests/oldpwd.c

@@ -1,21 +1,92 @@
 #include "common.h"
 
+#include <assert.h>
+
 /* change password on server */
 
+#define USER "freetds_oldpwd"
+#define PWD1 "TestPWD1?"
+#define PWD2 "OtherPWD2@"
+
 static void
 my_attrs(void)
 {
-	SQLSetConnectAttr(odbc_conn, 1226 /*SQL_COPT_SS_OLDPWD */ ,
-			  (SQLPOINTER) common_pwd.password, SQL_NTS);
-	strcpy(common_pwd.password, "testpwd$");
+	SQLSetConnectAttr(odbc_conn, 1226 /* SQL_COPT_SS_OLDPWD */ ,
+			  (SQLPOINTER) PWD1, SQL_NTS);
+	strcpy(common_pwd.user, USER);
+	strcpy(common_pwd.password, PWD2);
 }
 
 TEST_MAIN()
 {
+	const char *ci;
+	char *old_user, *old_pwd;
+
 	odbc_use_version3 = true;
+
+	/* Check if we are in CI */
+	ci = getenv("CI");
+	if (!ci || strcasecmp(ci, "true") != 0) {
+		odbc_test_skipped();
+		return 0;
+	}
+
+	odbc_connect();
+
+	/* minimum TDS 7.2 and MSSQL 2012 */
+	if (odbc_tds_version() < 0x702 || odbc_db_version_int() < 0x0a000000u) {
+		odbc_disconnect();
+		odbc_test_skipped();
+		return 0;
+	}
+
+	/* create new login for this test and disconnect */
+	odbc_command_with_result(odbc_stmt, "DROP LOGIN " USER);
+	odbc_command("CREATE LOGIN " USER " WITH PASSWORD='" PWD1 "' MUST_CHANGE, "
+		     "DEFAULT_DATABASE = tempdb, CHECK_EXPIRATION = ON");
+
+	odbc_disconnect();
+
+	old_user = strdup(common_pwd.user);
+	assert(old_user);
+	old_pwd = strdup(common_pwd.password);
+	assert(old_pwd);
+
+	/* login with new password should fail */
+	strcpy(common_pwd.user, USER);
+	strcpy(common_pwd.password, PWD1);
+
+	CHKAllocHandle(SQL_HANDLE_ENV, SQL_NULL_HANDLE, &odbc_env, "S");
+	SQLSetEnvAttr(odbc_env, SQL_ATTR_ODBC_VERSION, (SQLPOINTER) (SQL_OV_ODBC3), SQL_IS_UINTEGER);
+	CHKAllocHandle(SQL_HANDLE_DBC, odbc_env, &odbc_conn, "S");
+	CHKConnect(T(common_pwd.server), SQL_NTS, T(common_pwd.user), SQL_NTS, T(common_pwd.password), SQL_NTS, "E");
+	odbc_read_error();
+	if (strcmp(odbc_sqlstate, "42000") != 0 ||
+	    strstr(odbc_err, USER) == NULL || strstr(odbc_err, "The password of the account must be changed") == NULL) {
+		fprintf(stderr, "Unexpected sql state %s returned\n", odbc_sqlstate);
+		odbc_disconnect();
+		return 1;
+	}
+	odbc_disconnect();
+
+	/* login and change password */
 	odbc_set_conn_attr = my_attrs;
 	odbc_connect();
+	odbc_disconnect();
+
+	/* login wiht new password */
+	odbc_set_conn_attr = NULL;
+	odbc_connect();
+	odbc_disconnect();
 
+	/* drop created login */
+	strcpy(common_pwd.user, old_user);
+	free(old_user);
+	strcpy(common_pwd.password, old_pwd);
+	free(old_pwd);
+	odbc_connect();
+	odbc_command("DROP LOGIN " USER);
 	odbc_disconnect();
+
 	return 0;
 }