odbc: Set charset conversion based on binding type for BCP

Source can be either ANSI or wide, set character conversion
accordingly.
Extend test to test some conversions. CP850 encoding was chosen
as it encode some Latin1 characters in a different way.

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>

Author: freddy77

src/odbc/bcp.c

@@ -359,6 +359,7 @@ odbc_bcp_bind(TDS_DBC *dbc, const void * varaddr, int prefixlen, int varlen,
 	 const void * terminator, int termlen, int vartype, int table_column)
 {
 	TDSCOLUMN *colinfo;
+	TDSICONV *conv;
 
 	tdsdump_log(TDS_DBG_FUNC, "bcp_bind(%p, %p, %d, %d -- %p, %d, %d, %d)\n",
 						dbc, varaddr, prefixlen, varlen,
@@ -408,6 +409,16 @@ odbc_bcp_bind(TDS_DBC *dbc, const void * varaddr, int prefixlen, int varlen,
 	colinfo->column_bindlen  = varlen;
 	colinfo->bcp_prefix_len = prefixlen;
 
+	conv = colinfo->char_conv;
+	if (conv) {
+		TDSCONNECTION *conn = dbc->tds_socket->conn;
+		TDS_SERVER_TYPE desttype = tds_get_conversion_type(colinfo->on_server.column_type, colinfo->on_server.column_size);
+		TDS_SERVER_TYPE srctype = colinfo->column_bindtype == 0 ? desttype : (TDS_SERVER_TYPE) colinfo->column_bindtype;
+		int src_charset = is_unicode_type(srctype) ? odbc_get_wide_canonic(conn) : dbc->original_charset_num;
+
+		colinfo->char_conv = tds_iconv_get_info(conn, src_charset, conv->to.charset.canonic);
+	}
+
 	TDS_ZERO_FREE(colinfo->bcp_terminator);
 	colinfo->bcp_term_len = 0;
 	if (termlen > 0) {

src/odbc/unittests/bcp.c

@@ -52,7 +52,9 @@ static const char *expected_special[] = {
 	"2015-03-14 15:26:53.589793",
 	"3.141593000",
 	"3.141593",		/* MS driver has "3141593" here. Bug? Should we be bug-compatible? */
+	"hello",
 	"",
+	"\xd3\xd4"
 };
 
 static int tds_version;
@@ -132,7 +134,9 @@ init(void)
 		"dt2 datetime2(6) not null,"
 		"num decimal(19,9) not null,"
 		"numstr varchar(64) not null,"
+		"str nvarchar(6) not null,"
 		"empty varchar(64) not null,"
+		"cp varchar(64) collate SQL_Latin1_General_CP850_CI_AS not null,"
 		"bitnull bit null"
 		")");
 }
@@ -260,6 +264,7 @@ TEST_MAIN()
 	const char *s;
 
 	odbc_set_conn_attr = set_attr;
+	odbc_conn_additional_params = "ClientCharset=ISO-8859-1;";
 	odbc_connect();
 
 	tds_version = odbc_tds_version();
@@ -334,6 +339,7 @@ special_inserts(void)
 	SQL_TIMESTAMP_STRUCT timestamp;
 	DBDATETIME datetime;
 	SQL_NUMERIC_STRUCT numeric;
+	SQLWCHAR hello[6], oo[3];
 
 	printf("sending special types\n");
 	rows_sent = 0;
@@ -361,12 +367,16 @@ special_inserts(void)
 	numeric.val[0] = 0xd9;
 	numeric.val[1] = 0xef;
 	numeric.val[2] = 0x2f;
+	odbc_to_sqlwchar(hello, "hello", 6);
+	odbc_to_sqlwchar(oo, "\xd3\xd4", 3);
 	bcp_bind(odbc_conn, (unsigned char *) &datetime, 0, sizeof(datetime), NULL, 0, BCP_TYPE_SQLDATETIME, 1);
 	bcp_bind(odbc_conn, (unsigned char *) &timestamp, 0, sizeof(timestamp), NULL, 0, BCP_TYPE_SQLDATETIME2, 2);
 	bcp_bind(odbc_conn, (unsigned char *) &numeric, 0, sizeof(numeric), NULL, 0, BCP_TYPE_SQLDECIMAL, 3);
 	bcp_bind(odbc_conn, (unsigned char *) &numeric, 0, sizeof(numeric), NULL, 0, BCP_TYPE_SQLDECIMAL, 4);
-	bcp_bind(odbc_conn, (unsigned char *) "", 0, 0, NULL, 0, BCP_TYPE_SQLVARCHAR, 5);
-	bcp_bind(odbc_conn, (unsigned char *) &not_null_bit, 0, SQL_NULL_DATA, NULL, 0, BCP_TYPE_SQLINT4, 6);
+	bcp_bind(odbc_conn, (unsigned char *) hello, 0, 10, NULL, 0, BCP_TYPE_SQLNVARCHAR, 5);
+	bcp_bind(odbc_conn, (unsigned char *) "", 0, 0, NULL, 0, BCP_TYPE_SQLVARCHAR, 6);
+	bcp_bind(odbc_conn, (unsigned char *) oo, 0, 4, NULL, 0, BCP_TYPE_SQLNVARCHAR, 7);
+	bcp_bind(odbc_conn, (unsigned char *) &not_null_bit, 0, SQL_NULL_DATA, NULL, 0, BCP_TYPE_SQLINT4, 8);
 
 	if (bcp_sendrow(odbc_conn) == FAIL)
 		report_bcp_error("bcp_sendrow", __LINE__, __FILE__);