Skip to content

Commit 5ddfbcc

Browse files
committed
Address review comments
Fix padding issue with new icon in top bar, fix bug where Enter bypasses empty name restriction, adjust modal button styling, allow community posts to be bookmarked
1 parent 2941e15 commit 5ddfbcc

File tree

5 files changed

+21
-6
lines changed

5 files changed

+21
-6
lines changed

src/renderer/components/page-bookmark-prompt/page-bookmark-prompt.css

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,3 +7,8 @@
77
max-inline-size: 600px;
88
margin-inline: auto;
99
}
10+
11+
.actions-container {
12+
justify-content: center;
13+
column-gap: 10px;
14+
}

src/renderer/components/page-bookmark-prompt/page-bookmark-prompt.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,10 @@ export default defineComponent({
6363
},
6464

6565
save: function () {
66+
if (this.name === '') {
67+
return
68+
}
69+
6670
const pageBookmark = {
6771
route: this.$router.currentRoute.fullPath,
6872
name: this.name,

src/renderer/components/page-bookmark-prompt/page-bookmark-prompt.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@
2424
<p>{{ duplicateNameMessage }}</p>
2525
</ft-flex-box>
2626
</div>
27-
<div class="actions-container">
28-
<ft-flex-box>
27+
<div>
28+
<ft-flex-box class="actions-container">
2929
<ft-button
3030
v-if="!isBookmarkBeingCreated"
3131
:label="$t('Page Bookmark.Remove Bookmark')"

src/renderer/components/top-nav/top-nav.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ export default defineComponent({
5353
'Channel',
5454
'Watch',
5555
'Hashtag',
56+
'Post',
5657
'Settings' // for linkable settings sections
5758
],
5859
lastSuggestionQuery: ''

src/renderer/components/top-nav/top-nav.scss

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323

2424
@media only screen and (width >= 1162px) {
2525
display: grid;
26-
grid-template-columns: 1fr 720px 0.5fr 0.5fr;
26+
grid-template-columns: 1fr 440px 0.5fr 0.5fr;
2727
}
2828

2929
@include top-nav-is-colored {
@@ -124,9 +124,14 @@
124124
}
125125
}
126126

127-
.pageBookmarkIcon.favorite {
128-
@include top-nav-is-colored {
129-
color: var(--accent-color);
127+
.pageBookmarkIcon {
128+
inline-size: fit-content;
129+
padding: 10px;
130+
131+
&.favorite {
132+
@include top-nav-is-colored {
133+
color: var(--accent-color);
134+
}
130135
}
131136
}
132137

0 commit comments

Comments
 (0)