refactor(discord): remove unnecessary method

Signed-off-by: so5iso4ka <[email protected]>

Author: so5iso4ka

launcher/Application.cpp

@@ -1422,11 +1422,6 @@ bool Application::openJsonEditor(const QString& filename)
     }
 }
 
-void Application::showInDiscord()
-{
-    discord()->showAlways(m_settings->get("AlwaysShowInDiscord").toBool());
-}
-
 bool Application::launch(InstancePtr instance, bool online, bool demo, MinecraftTarget::Ptr targetToJoin, BaseAccountPtr accountToUse)
 {
     if (m_updateRunning) {

launcher/Application.h

@@ -187,8 +187,6 @@ class Application : public QApplication {
      */
     bool openJsonEditor(const QString& filename);
 
-    void showInDiscord();
-
     InstanceWindow* showInstanceWindow(InstancePtr instance, QString page = QString());
     MainWindow* showMainWindow(bool minimized = false);
 

launcher/ui/pages/global/LauncherPage.cpp

@@ -49,6 +49,7 @@
 #include "Application.h"
 #include "BuildConfig.h"
 #include "DesktopServices.h"
+#include "discord/DiscordIntegration.h"
 #include "settings/SettingsObject.h"
 #include "ui/themes/ITheme.h"
 #include "ui/themes/ThemeManager.h"
@@ -106,7 +107,6 @@ LauncherPage::~LauncherPage()
 bool LauncherPage::apply()
 {
     applySettings();
-    APPLICATION->showInDiscord();
     return true;
 }
 
@@ -280,7 +280,9 @@ void LauncherPage::applySettings()
     s->set("ModDependenciesDisabled", ui->dependenciesDisableBtn->isChecked());
     s->set("SkipModpackUpdatePrompt", ui->skipModpackUpdatePromptBtn->isChecked());
 
-    s->set("AlwaysShowInDiscord", ui->discordBtn->isChecked());
+    const auto showInDiscord = ui->discordBtn->isChecked();
+    s->set("AlwaysShowInDiscord", showInDiscord);
+    APPLICATION->discord()->showAlways(showInDiscord);
 }
 
 void LauncherPage::loadSettings()