Merge pull request #20 from pamil/renaming

pamil · web-flow · commit 1f74a21c8dbc · 2017-07-10T23:06:20.000+02:00
Rename to ExcludeSpecificationsExtension
diff --git a/README.md b/README.md
@@ -1,26 +1,26 @@
-# Skip Extension [![License](https://img.shields.io/packagist/l/friends-of-behat/skip-extension.svg)](https://packagist.org/packages/friends-of-behat/skip-extension) [![Version](https://img.shields.io/packagist/v/friends-of-behat/skip-extension.svg)](https://packagist.org/packages/friends-of-behat/skip-extension) [![Build status on Linux](https://img.shields.io/travis/FriendsOfBehat/SkipExtension/master.svg)](http://travis-ci.org/FriendsOfBehat/SkipExtension) [![Scrutinizer Quality Score](https://img.shields.io/scrutinizer/g/FriendsOfBehat/SkipExtension.svg)](https://scrutinizer-ci.com/g/FriendsOfBehat/SkipExtension/)
+# Exclude Specifications Extension [![License](https://img.shields.io/packagist/l/friends-of-behat/exclude-specifications-extension.svg)](https://packagist.org/packages/friends-of-behat/exclude-specifications-extension) [![Version](https://img.shields.io/packagist/v/friends-of-behat/exclude-specifications-extension.svg)](https://packagist.org/packages/friends-of-behat/exclude-specifications-extension) [![Build status on Linux](https://img.shields.io/travis/FriendsOfBehat/ExcludeSpecificationsExtension/master.svg)](http://travis-ci.org/FriendsOfBehat/ExcludeSpecificationsExtension) [![Scrutinizer Quality Score](https://img.shields.io/scrutinizer/g/FriendsOfBehat/ExcludeSpecificationsExtension.svg)](https://scrutinizer-ci.com/g/FriendsOfBehat/ExcludeSpecificationsExtension/)
 
-Allows to skip features and scenarios in Behat tests.
+Allows to exclude features or scenarios in Behat tests.
 
 ## Usage
 
 1. Install it:
     
     ```bash
-    $ composer require friends-of-behat/skip-extension --dev
+    $ composer require friends-of-behat/exclude-specifications-extension --dev
     ```
 
-2. Enable it in your Behat configuration and list features that needs to be skipped:
+2. Enable it in your Behat configuration and list features that needs to be excluded:
     
     ```yaml
     # behat.yml
     default:
         # ...
         extensions:
-            SkipExtension:
+            FriendsOfBehat\ExcludeSpecificationsExtension:
                features:
                    - vendor/library/features/feature_to_be_skipped.feature
                    - vendor/library/features/another_feature_to_be_skipped.feature
     ```
 
-3. That's it! :tada: Listed features are going to be skipped while executing Behat tests.
+3. That's it! :tada: Listed features are going to be excluded while executing Behat tests.
diff --git a/composer.json b/composer.json
@@ -1,6 +1,6 @@
 {
-    "name": "friends-of-behat/skip-extension",
-    "description": "Allows to skip features and scenarios in Behat tests.",
+    "name": "friends-of-behat/exclude-specifications-extension",
+    "description": "Allows to exclude features or scenarios in Behat tests.",
     "license": "MIT",
     "authors": [
         {
@@ -16,14 +16,12 @@
     },
     "require-dev": {
         "friends-of-behat/test-context": "^1.0",
-        "phpspec/phpspec": "^4.0@alpha",
-
-        "doctrine/instantiator": "^1.0.5"
+        "phpspec/phpspec": "^4.0@alpha"
     },
     "autoload": {
-        "psr-4": { "FriendsOfBehat\\SkipExtension\\": "src/" }
+        "psr-4": { "FriendsOfBehat\\ExcludeSpecificationsExtension\\": "src/" }
     },
     "autoload-dev": {
-        "psr-4" : { "spec\\FriendsOfBehat\\SkipExtension\\": "spec/" }
+        "psr-4" : { "spec\\FriendsOfBehat\\ExcludeSpecificationsExtension\\": "spec/" }
     }
 }
diff --git a/features/excluding_single_feature_file.feature b/features/excluding_single_feature_file.feature
@@ -1,16 +1,16 @@
 Feature: Skipping single feature file
     In order to not run Behat feature which I don't want to be executed
     As a Behat User
-    I want to skip specific files
+    I want to exclude specific files
 
-    Background:
+    Scenario: Excluded features are not execuded
         Given a Behat configuration containing:
         """
         default:
             extensions:
-                FriendsOfBehat\SkipExtension:
+                FriendsOfBehat\ExcludeSpecificationsExtension:
                     features:
-                        - "features/skip.feature"
+                        - "features/excluded.feature"
         """
         And a context file "features/bootstrap/FeatureContext.php" containing:
         """
@@ -28,22 +28,20 @@ Feature: Skipping single feature file
             }
         }
         """
-        And a feature file "features/skip.feature" containing:
+        And a feature file "features/excluded.feature" containing:
         """
-        Feature: Feature to skip
+        Feature: Feature to exclude
 
             Scenario: Doing nothing
                 When I do nothing
         """
-        And a feature file "features/run.feature" containing:
+        And a feature file "features/not_excluded.feature" containing:
         """
-        Feature: Feature to run
+        Feature: Feature not to exclude
 
             Scenario: Doing nothing
                 When I do nothing
         """
-
-    Scenario: Seeing proper number of passed scenarios
         When I run Behat
         Then it should pass with:
         """
diff --git a/phpspec.yml.dist b/phpspec.yml.dist
@@ -1,4 +1,4 @@
 suites:
     main:
-        namespace: FriendsOfBehat\SkipExtension
-        psr4_prefix: FriendsOfBehat\SkipExtension
+        namespace: FriendsOfBehat\ExcludeSpecificationsExtension
+        psr4_prefix: FriendsOfBehat\ExcludeSpecificationsExtension
diff --git a/spec/Locator/ExcludingSpecificationIteratorSpec.php b/spec/Locator/ExcludingSpecificationIteratorSpec.php
@@ -3,20 +3,20 @@
 declare(strict_types=1);
 
 /*
- * This file is part of the SkipExtension package.
+ * This file is part of the ExcludeSpecificationsExtension package.
  *
  * (c) Kamil Kokot <kamil@kokot.me>
  *
  * For the full copyright and license information, please view the LICENSE
  * file that was distributed with this source code.
  */
 
-namespace spec\FriendsOfBehat\SkipExtension\Locator;
+namespace spec\FriendsOfBehat\ExcludeSpecificationsExtension\Locator;
 
 use Behat\Testwork\Specification\SpecificationIterator;
 use PhpSpec\ObjectBehavior;
 
-final class SkipAwareSpecificationIteratorSpec extends ObjectBehavior
+final class ExcludingSpecificationIteratorSpec extends ObjectBehavior
 {
     function let(SpecificationIterator $specificationIterator): void
     {
diff --git a/src/Locator/ExcludingSpecificationIterator.php b/src/Locator/ExcludingSpecificationIterator.php
@@ -3,23 +3,23 @@
 declare(strict_types=1);
 
 /*
- * This file is part of the SkipExtension package.
+ * This file is part of the ExcludeSpecificationsExtension package.
  *
  * (c) Kamil Kokot <kamil@kokot.me>
  *
  * For the full copyright and license information, please view the LICENSE
  * file that was distributed with this source code.
  */
 
-namespace FriendsOfBehat\SkipExtension\Locator;
+namespace FriendsOfBehat\ExcludeSpecificationsExtension\Locator;
 
 use Behat\Testwork\Specification\SpecificationIterator;
 use Behat\Testwork\Suite\Suite;
 
 /**
  * @internal
  */
-final class SkipAwareSpecificationIterator extends \FilterIterator implements SpecificationIterator
+final class ExcludingSpecificationIterator extends \FilterIterator implements SpecificationIterator
 {
     /**
      * @var SpecificationIterator
diff --git a/src/Locator/ExcludingSpecificationLocator.php b/src/Locator/ExcludingSpecificationLocator.php
@@ -3,15 +3,15 @@
 declare(strict_types=1);
 
 /*
- * This file is part of the SkipExtension package.
+ * This file is part of the ExcludeSpecificationsExtension package.
  *
  * (c) Kamil Kokot <kamil@kokot.me>
  *
  * For the full copyright and license information, please view the LICENSE
  * file that was distributed with this source code.
  */
 
-namespace FriendsOfBehat\SkipExtension\Locator;
+namespace FriendsOfBehat\ExcludeSpecificationsExtension\Locator;
 
 use Behat\Testwork\Specification\Locator\SpecificationLocator;
 use Behat\Testwork\Specification\SpecificationIterator;
@@ -20,7 +20,7 @@
 /**
  * @internal
  */
-final class SkipAwareSpecificationLocator implements SpecificationLocator
+final class ExcludingSpecificationLocator implements SpecificationLocator
 {
     /**
      * @var SpecificationLocator
@@ -55,7 +55,7 @@ public function getLocatorExamples(): array
      */
     public function locateSpecifications(Suite $suite, $locator): SpecificationIterator
     {
-        return new SkipAwareSpecificationIterator(
+        return new ExcludingSpecificationIterator(
             $this->specificationLocator->locateSpecifications($suite, $locator),
             $this->skippedPaths
         );
diff --git a/src/ServiceContainer/ExcludeSpecificationsExtension.php b/src/ServiceContainer/ExcludeSpecificationsExtension.php
@@ -3,32 +3,32 @@
 declare(strict_types=1);
 
 /*
- * This file is part of the SkipExtension package.
+ * This file is part of the ExcludeSpecificationsExtension package.
  *
  * (c) Kamil Kokot <kamil@kokot.me>
  *
  * For the full copyright and license information, please view the LICENSE
  * file that was distributed with this source code.
  */
 
-namespace FriendsOfBehat\SkipExtension\ServiceContainer;
+namespace FriendsOfBehat\ExcludeSpecificationsExtension\ServiceContainer;
 
 use Behat\Testwork\ServiceContainer\Extension;
 use Behat\Testwork\ServiceContainer\ExtensionManager;
-use FriendsOfBehat\SkipExtension\Locator\SkipAwareSpecificationLocator;
+use FriendsOfBehat\ExcludeSpecificationsExtension\Locator\ExcludingSpecificationLocator;
 use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Definition;
 use Symfony\Component\DependencyInjection\Reference;
 
-final class SkipExtension implements Extension
+final class ExcludeSpecificationsExtension implements Extension
 {
     /**
      * {@inheritdoc}
      */
     public function getConfigKey(): string
     {
-        return 'fob_skip';
+        return 'fob_exclude_specifications';
     }
 
     /**
@@ -58,15 +58,15 @@ public function configure(ArrayNodeDefinition $builder): void
      */
     public function load(ContainerBuilder $container, array $config): void
     {
-        $definition = new Definition(SkipAwareSpecificationLocator::class, [
-            new Reference('specifications.locator.filesystem_feature.skip_aware.inner'),
+        $definition = new Definition(ExcludingSpecificationLocator::class, [
+            new Reference('specifications.locator.filesystem_feature.excluding.inner'),
             $this->getAbsoluteSkippedPaths($config['features'], $container->getParameter('paths.base'))
         ]);
 
         $definition->setDecoratedService('specifications.locator.filesystem_feature');
         $definition->setPublic(false);
 
-        $container->setDefinition('specifications.locator.filesystem_feature.skip_aware', $definition);
+        $container->setDefinition('specifications.locator.filesystem_feature.excluding', $definition);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -3,20 +3,20 @@`
`3`	`3`	`declare(strict_types=1);`
`4`	`4`
`5`	`5`	`/*`
`6`		`- * This file is part of the SkipExtension package.`
	`6`	`+ * This file is part of the ExcludeSpecificationsExtension package.`
`7`	`7`	`*`
`8`	`8`	`* (c) Kamil Kokot <kamil@kokot.me>`
`9`	`9`	`*`
`10`	`10`	`* For the full copyright and license information, please view the LICENSE`
`11`	`11`	`* file that was distributed with this source code.`
`12`	`12`	`*/`
`13`	`13`
`14`		`-namespace spec\FriendsOfBehat\SkipExtension\Locator;`
	`14`	`+namespace spec\FriendsOfBehat\ExcludeSpecificationsExtension\Locator;`
`15`	`15`
`16`	`16`	`use Behat\Testwork\Specification\SpecificationIterator;`
`17`	`17`	`use PhpSpec\ObjectBehavior;`
`18`	`18`
`19`		`-final class SkipAwareSpecificationIteratorSpec extends ObjectBehavior`
	`19`	`+final class ExcludingSpecificationIteratorSpec extends ObjectBehavior`
`20`	`20`	`{`
`21`	`21`	`function let(SpecificationIterator $specificationIterator): void`
`22`	`22`	`{`