Add more functional tests

[ddeboer]

Add more functional tests against the Symfony test app:

• config tag expressions
• UserContextSubscriber testing that user context request is handled correctly #382
• InvalidatePath and InvalidateRoute annotations => Cleanup invalidation annotation #121
• Rule match on controllers with short notation vs full namespace
• Request in expression (added in also provide request itself in expressions #144)
• Symfony HttpCache: user context

[dbu]

@joelwurtz how would you feel about writing a full integration test about the user context feature? ddeboer is extracting the testing infrastructure in #122 - with this it should become possible to run tests with varnish in the bundle. given the complexity of the interaction, a functional test that goes end to end could be interesting i think.

[ddeboer]

I’m here with @joelwurtz at the SymfonyCon hackday, and we doubt whether it makes sense to introduce Varnish into the bundle for integration tests. After all, we already test our context VCL in the library.

@dbu Wdyt?

[ddeboer]

For the short controller names I guess we need to create some dummy TestBundle, right?

[dbu]

yeah, its a lot of additional things and redundance in testing. but we could simulate the requests in a WebTestCase and see if the right answers come back. though we might actually even do that already if there are functional tests for the HttpCache kernel class...

what do you mean with the short controller names? is that not covered by the symfony core tests on the request matcher?