[2.0] Support for Symfony 5.0

[alcaeus]

This serves as an epic to collect all issues and pull requests arising with Symfony 5 support.

[OneEyedSpaceFish]

@alcaeus
Would that be possible to merge all outstanding PRs for 2.0 into a feature branch?
That way it would be possible for people to start testing their own application with symfony 5.0 beta before it's release.

[alcaeus]

I'll do a session to take care of Symfony 5 support next week. Sorry for the delay here, but I've been quite busy with @doctrine packages.

[cpjolly]

I don't see it mentioned elsewhere so please note that the base server library FriendsOfSymfony/oauth2-php will also need a few minor incremental changes to support Symfony 5. For example, it's composer.json requires "symfony/http-foundation": "~3.0|~4.0"

Also, in it's master branch there is a new Interface for OAuth2 but there is no dot tagged release with this important improvement

[OneEyedSpaceFish]

@alcaeus
Do you need a hand with the migration?
If you explain what you planned to do, I wouldn't mind taking a look.

[alcaeus]

In a nutshell:

• Update composer constraints to allow Symfony 5
• Ensure Symfony 5 is tested on travis-ci
• Update code to avoid breakages and deprecations due to Symfony
• repeat above until build is stable

If you're interested, please go ahead 👍

[OneEyedSpaceFish]

@alcaeus Are there any pending PRs that you would like to include in this change request?

[alcaeus]

Taking a quick look, you want to check out #599, #610, #617, #619, and #623 - they sound like they could affect this. I'd have to take a closer look to know for sure.

[cpjolly]

@alcaeus I can confirm that the issues described and the proposed fixes in #599, #610, #617, #619, and #623 are the same for Symfony 5.0. Also note #501.

[OneEyedSpaceFish]

Just an FYI; I started to have a look at this, but there's no much progress made so far, as I'm extremely busy nowadays and have very little time.

So if someone would like to have a look before I can sort this out, feel free to do so.

[sci3ma]

Any updates when we can use FOSOAuthServerBundle with Symfony 5?

[OneEyedSpaceFish]

@sci3ma none from me yet, I've been too busy with work.
Feel free to have a look

[elchris]

I've started some work on my fork here: https://github.com/elchris/FOSOAuthServerBundle/tree/symfony-5

it also references another fork of mine for the oauth2-php project

i just got the tests to "compile", resolved composer dependencies, etc.

• composer install
• ./vendor/bin/phpunit

Errors: 21, Failures: 6, Warnings: 18, Incomplete: 2.

If anyone wants to submit to me a pull request against my "symfony-5" branch with some incremental fixes to the tests, i'd be happy to merge them. @OneEyedSpaceFish fyi :)

This article will be relevant for OAuthListenerTest which references Symfony\Component\Security\Core\SecurityContextInterface which was deprecated.