Skip to content

Commit 89db930

Browse files
committed
Fix the wiring of controllers
Controllers extending AbstractController must be wired as service subscribers. They should not get the main container injected in them.
1 parent 2a7efdf commit 89db930

File tree

5 files changed

+10
-5
lines changed

5 files changed

+10
-5
lines changed

Resources/config/change_password.xml

+2-1
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,9 @@
2222
<argument type="service" id="fos_user.change_password.form.factory" />
2323
<argument type="service" id="fos_user.user_manager" />
2424
<call method="setContainer">
25-
<argument type="service" id="service_container" />
25+
<argument type="service" id="Psr\Container\ContainerInterface" />
2626
</call>
27+
<tag name="container.service_subscriber" />
2728
</service>
2829

2930
<service id="FOS\UserBundle\Controller\ChangePasswordController" alias="fos_user.change_password.controller" public="true" />

Resources/config/profile.xml

+2-1
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,9 @@
2323
<argument type="service" id="fos_user.profile.form.factory" />
2424
<argument type="service" id="fos_user.user_manager" />
2525
<call method="setContainer">
26-
<argument type="service" id="service_container" />
26+
<argument type="service" id="Psr\Container\ContainerInterface" />
2727
</call>
28+
<tag name="container.service_subscriber" />
2829
</service>
2930

3031
<service id="FOS\UserBundle\Controller\ProfileController" alias="fos_user.profile.controller" public="true" />

Resources/config/registration.xml

+2-1
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,9 @@
2424
<argument type="service" id="fos_user.user_manager" />
2525
<argument type="service" id="security.token_storage" />
2626
<call method="setContainer">
27-
<argument type="service" id="service_container" />
27+
<argument type="service" id="Psr\Container\ContainerInterface" />
2828
</call>
29+
<tag name="container.service_subscriber" />
2930
</service>
3031

3132
<service id="FOS\UserBundle\Controller\RegistrationController" alias="fos_user.registration.controller" public="true" />

Resources/config/resetting.xml

+2-1
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,9 @@
3232
<argument type="service" id="fos_user.mailer" />
3333
<argument>%fos_user.resetting.retry_ttl%</argument>
3434
<call method="setContainer">
35-
<argument type="service" id="service_container" />
35+
<argument type="service" id="Psr\Container\ContainerInterface" />
3636
</call>
37+
<tag name="container.service_subscriber" />
3738
</service>
3839

3940
<service id="FOS\UserBundle\Controller\ResettingController" alias="fos_user.resetting.controller" public="true" />

Resources/config/security.xml

+2-1
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,9 @@
4141
<argument type="service" id="security.authentication_utils" />
4242
<argument type="service" id="security.csrf.token_manager" on-invalid="null" />
4343
<call method="setContainer">
44-
<argument type="service" id="service_container" />
44+
<argument type="service" id="Psr\Container\ContainerInterface" />
4545
</call>
46+
<tag name="container.service_subscriber" />
4647
</service>
4748

4849
<service id="FOS\UserBundle\Controller\SecurityController" alias="fos_user.security.controller" public="true" />

0 commit comments

Comments
 (0)