Merge pull request #22 from eFaqtBV/on-demand-hydration-fix

j0k3r · web-flow · commit 0564971b2bad · 2016-06-17T11:49:47.000+02:00
Do not close cursors while using ON_DEMAND hydration
diff --git a/lib/Doctrine/Hydrator/Graph.php b/lib/Doctrine/Hydrator/Graph.php
@@ -105,7 +105,6 @@ public function hydrateResultSet($stmt)
             } else {
                 $data = $stmt->fetch(Doctrine_Core::FETCH_ASSOC);
                 if ( ! $data) {
-                    $stmt->closeCursor();
                     return $result;
                 }
             }
@@ -136,7 +135,6 @@ public function hydrateResultSet($stmt)
                 } else if ($activeRootIdentifier != $id[$rootAlias]) {
                     // first row for the next record
                     $this->_priorRow = $data;
-                    $stmt->closeCursor();
                     return $result;
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,6 @@ public function hydrateResultSet($stmt)`
`105`	`105`	`} else {`
`106`	`106`	`$data = $stmt->fetch(Doctrine_Core::FETCH_ASSOC);`
`107`	`107`	`if ( ! $data) {`
`108`		`- $stmt->closeCursor();`
`109`	`108`	`return $result;`
`110`	`109`	`}`
`111`	`110`	`}`
`@@ -136,7 +135,6 @@ public function hydrateResultSet($stmt)`
`136`	`135`	`} else if ($activeRootIdentifier != $id[$rootAlias]) {`
`137`	`136`	`// first row for the next record`
`138`	`137`	`$this->_priorRow = $data;`
`139`		`- $stmt->closeCursor();`
`140`	`138`	`return $result;`
`141`	`139`	`}`
`142`	`140`	`}`