sfCoreAutoload::make() doesn't work

[JohannesTyra]

Hey Team,
the sfCoreAutoload::make() doesn't work.

https://github.com/FriendsOfSymfony1/symfony1/blob/master/lib/autoload/sfCoreAutoload.class.php

The preg_replace needs the "old PHP array syntax":
preg_replace('/protected \$classes = array *\(.*?\);/s',

In the code the new syntax protected $classes = [***] is used - without array.
So the preg_replace fails.

---

Using

    protected $classes = array(
    'sfaction' => 'action/sfAction.class.php',
    'sfactionstack' => 'action/sfActionStack.class.php',
    'sfactionstackentry' => 'action/sfActionStackEntry.class.php',

fixes it.

---

Thx for support.

[JohannesTyra]

@thePanz This issue was caused by this change.

53a2b12#diff-eaebe010ea1054743688dffd43445400da8d71e461475fbd0910c23f4a4dbc63

[JohannesTyra]

Otherwise this pattern will fix it also:

'/protected \$classes = (array|\\[) *\(.*?\);/s'

This matches both array(...) and [...] declarations.

[vendethiel]

Doesn’t the end part ()) also need to be fixed?

[JohannesTyra]

@vendethiel You are right.

This code works for both declarations and using the new style in the replace.

$content = preg_replace('/protected \$classes = (array|\\[) *(.*?);/s', sprintf("protected \$classes = [\n%s ];", $classes), file_get_contents(__FILE__));

[thePanz]

@JohannesTyra @vendethiel thanks for the report! I was using the latest release of SF1, but did not get the error.
Can you help me to reproduce it? Thanks!

[JohannesTyra]

@thePanz Which declaration you have in the latest relaese?

53a2b12#diff-eaebe010ea1054743688dffd43445400da8d71e461475fbd0910c23f4a4dbc63

... array() OR [] ?

The preg_replace works only on the array() syntax.

[thePanz]

the latest release uses the short array syntax.

How can I reproduce the error?

[JohannesTyra]

Try to call sfCoreAutoload::make() .. the function uses the old array syntax (not short).
So it does not match.

I build up a custom task for this.

<?php

class sfAutoloadTestTask extends sfBaseTask
{
  protected function configure()
  {
    $this->namespace = 'test';
    $this->name = 'autoload';
    $this->briefDescription = 'Tests sfCoreAutoload::make() functionality';

    // Optionally, add arguments or options if needed
  }

  protected function execute($arguments = array(), $options = array())
  {
    // Call sfCoreAutoload::make()
    sfCoreAutoload::make();

    // Check if autoloading works
    if (class_exists('sfCoreAutoload')) {
      $this->logSection('autoload', 'Autoloading is initialized and sfCoreAutoload is available.');
    } else {
      $this->logSection('autoload', 'Autoloading failed.');
    }
  }
}

[thePanz]

@JohannesTyra @vendethiel can you check if the following solves your issue?
$content = preg_replace('/protected \$classes = (array|\\[) *\(.*?\);/s', sprintf("protected \$classes = [\n%s ];", $classes), file_get_contents(__FILE__));

I adjusted your suggestion, adding escapes to the parenthesis (ref: *\(.*?\);/s)