[BUGFIX] Fix #785: Change SelectProperty type from int to string

TYPO3 type=select fields store values as varchar(255), but the generated
PHP model used int type and int(11) SQL — causing a type mismatch in the
backend and runtime errors when select items have string values.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: PKuhlmay

Classes/Domain/Model/DomainObject/SelectProperty.php

@@ -22,22 +22,22 @@ class SelectProperty extends AbstractProperty
     /**
      * the property's default value
      *
-     * @var int
+     * @var string
      */
-    protected $defaultValue = 0;
+    protected $defaultValue = '';
 
     public function getTypeForComment(): string
     {
-        return 'int';
+        return 'string';
     }
 
     public function getTypeHint(): string
     {
-        return 'int';
+        return 'string';
     }
 
     public function getSqlDefinition(): string
     {
-        return $this->getFieldName() . " int(11) DEFAULT '0' NOT NULL,";
+        return $this->getFieldName() . " varchar(255) NOT NULL DEFAULT '',";
     }
 }

Tests/Functional/FileGenerator/Property/GeneratedPropertyTest.php

@@ -920,13 +920,13 @@ public function writeModelClassWithSelectProperty(): void
         $classFileContent = $this->fileGenerator->generateDomainObjectCode($domainObject);
 
         self::assertMatchesRegularExpression(
-            '/.*\* @var int.*/',
+            '/.*\* @var string.*/',
             $classFileContent,
             'var tag for select property was not generated'
         );
 
         self::assertMatchesRegularExpression(
-            '/.*protected \\$color = 0;.*/',
+            "/.*protected \\\$color = '';.*/",
             $classFileContent,
             'select property was not generated'
         );
@@ -937,7 +937,7 @@ public function writeModelClassWithSelectProperty(): void
             'Getter for select property was not generated'
         );
         self::assertMatchesRegularExpression(
-            '/.*public function setColor\(int \$color\).*/',
+            '/.*public function setColor\(string \$color\).*/',
             $classFileContent,
             'Setter for select property was not generated'
         );

Tests/Unit/Domain/Model/DomainObject/SelectPropertySqlTest.php

@@ -0,0 +1,61 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * This file is part of the TYPO3 CMS project.
+ *
+ * It is free software; you can redistribute it and/or modify it under
+ * the terms of the GNU General Public License, either version 2
+ * of the License, or any later version.
+ *
+ * For the full copyright and license information, please read the
+ * LICENSE.txt file that was distributed with this source code.
+ *
+ * The TYPO3 project - inspiring people to share!
+ */
+
+namespace EBT\ExtensionBuilder\Tests\Unit\Domain\Model\DomainObject;
+
+use EBT\ExtensionBuilder\Domain\Model\DomainObject\SelectProperty;
+use EBT\ExtensionBuilder\Tests\BaseUnitTest;
+
+/**
+ * Select properties are stored as varchar(255) in TYPO3, consistent with
+ * the TCA type=select schema and the fact that item values can be strings.
+ */
+class SelectPropertySqlTest extends BaseUnitTest
+{
+    /**
+     * @test
+     */
+    public function selectPropertyReturnsVarcharSqlDefinition(): void
+    {
+        $property = new SelectProperty();
+        $property->setName('status');
+        $property->setDomainObject($this->buildDomainObject('TestModel'));
+
+        self::assertSame(
+            "status varchar(255) NOT NULL DEFAULT '',",
+            $property->getSqlDefinition()
+        );
+    }
+
+    /**
+     * @test
+     */
+    public function selectPropertyTypeForCommentIsString(): void
+    {
+        $property = new SelectProperty();
+        self::assertSame('string', $property->getTypeForComment());
+    }
+
+    /**
+     * @test
+     */
+    public function selectPropertyTypeHintIsString(): void
+    {
+        $property = new SelectProperty();
+        self::assertSame('string', $property->getTypeHint());
+    }
+}

Tests/Unit/Service/ClassBuilderTest.php

@@ -195,7 +195,7 @@ public static function propertyDefaultTypesProviderTypes(): array
             'nativeDateTime' => ['nativeDateTime', null],
             'password' => ['password', ''],
             'richText' => ['richText', ''],
-            'select' => ['select', 0],
+            'select' => ['select', ''],
             'string' => ['string', ''],
             'text' => ['text', ''],
             'nativeTime' => ['nativeTime', null],