Skip to content

Commit 92bc5a2

Browse files
committed
[TASK] Fix pre-existing CI linter failures
- Remove unused FileGenerator import in RoundTripDomainObjectDeleteTest - Sync package-lock.json with package.json (missing @types/node, undici-types)
1 parent d8ee1cb commit 92bc5a2

4 files changed

Lines changed: 35 additions & 8 deletions

File tree

Tests/Functional/Service/RoundTripBackupRestoreTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919

2020
use EBT\ExtensionBuilder\Service\RoundTrip;
2121
use EBT\ExtensionBuilder\Tests\BaseFunctionalTest;
22+
use Exception;
2223
use TYPO3\CMS\Core\Core\Environment;
2324

2425
class RoundTripBackupRestoreTest extends BaseFunctionalTest
@@ -137,7 +138,7 @@ public function restoreBackupCreatesNestedBackupBeforeRestoring(): void
137138
*/
138139
public function restoreBackupThrowsExceptionForInvalidDirectoryName(): void
139140
{
140-
$this->expectException(\Exception::class);
141+
$this->expectException(Exception::class);
141142
RoundTrip::restoreBackup($this->extension, '../etc/passwd', $this->backupRelDir);
142143
}
143144
}

Tests/Functional/Service/RoundTripDomainObjectDeleteTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919

2020
use EBT\ExtensionBuilder\Configuration\ExtensionBuilderConfigurationManager;
2121
use EBT\ExtensionBuilder\Service\ExtensionSchemaBuilder;
22-
use EBT\ExtensionBuilder\Service\FileGenerator;
2322
use EBT\ExtensionBuilder\Service\ParserService;
2423
use EBT\ExtensionBuilder\Service\RoundTrip;
2524
use EBT\ExtensionBuilder\Tests\BaseFunctionalTest;

package-lock.json

Lines changed: 33 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

phpstan-baseline.neon

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -510,12 +510,6 @@ parameters:
510510
count: 2
511511
path: Classes/Service/FileGenerator.php
512512

513-
-
514-
message: '#^Left side of && is always true\.$#'
515-
identifier: booleanAnd.leftAlwaysTrue
516-
count: 1
517-
path: Classes/Service/FileGenerator.php
518-
519513
-
520514
message: '#^PHPDoc tag @return has invalid value \(void;\)\: Unexpected token ";", expected TOKEN_HORIZONTAL_WS at offset 157 on line 6$#'
521515
identifier: phpDoc.parseError

0 commit comments

Comments
 (0)