[TASK] Fix #729: Add extbase as dependency to generated extensions

Always include typo3/cms-extbase in generated extensions since all
Extension Builder extensions use Extbase by definition. Adds the
dependency to composer.json (require) and ext_emconf.php (depends).

Also removes dead v12 code from getVersionConstraints() since the
UI only offers TYPO3 v13.4 as a target version.

Existing user-defined extbase constraints are preserved.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: PKuhlmay

Classes/Domain/Model/Extension.php

@@ -568,7 +568,11 @@ public function setDependencies(array $dependencies): void
 
     public function getDependencies(): array
     {
-        return $this->dependencies;
+        $dependencies = $this->dependencies;
+        if (!array_key_exists('extbase', $dependencies)) {
+            $dependencies['extbase'] = '13.4.0-13.4.99';
+        }
+        return $dependencies;
     }
 
     public function setTargetVersion(float $targetVersion): void
@@ -660,6 +664,7 @@ public function getComposerInfo(): array
             'require' => [
                 'php' => $versionConstraints['php'],
                 'typo3/cms-core' => $versionConstraints['typo3/cms-core'],
+                'typo3/cms-extbase' => $versionConstraints['typo3/cms-extbase'],
             ],
             'require-dev' => [
                 'typo3/testing-framework' => $versionConstraints['typo3/testing-framework'],
@@ -704,18 +709,11 @@ public function getComposerInfo(): array
 
     private function getVersionConstraints(): array
     {
-        $majorVersion = (int)$this->targetVersion;
-        return match ($majorVersion) {
-            12 => [
-                'php' => '>=8.1',
-                'typo3/cms-core' => '^12.4',
-                'typo3/testing-framework' => '^8.0',
-            ],
-            default => [
-                'php' => '>=8.2',
-                'typo3/cms-core' => '^13.4',
-                'typo3/testing-framework' => '^9.0',
-            ],
-        };
+        return [
+            'php' => '>=8.2',
+            'typo3/cms-core' => '^13.4',
+            'typo3/cms-extbase' => '^13.4',
+            'typo3/testing-framework' => '^9.0',
+        ];
     }
 }

Tests/Fixtures/TestExtensions/eb_astrophotography/ext_emconf.php

@@ -10,6 +10,7 @@
     'version' => '',
     'constraints' => [
         'depends' => [
+            'extbase' => '13.4.0-13.4.99',
         ],
         'conflicts' => [],
         'suggests' => [],

Tests/Fixtures/TestExtensions/test_extension/composer.json

@@ -11,7 +11,8 @@
 	"license": "GPL-2.0-or-later",
 	"require": {
 		"php": ">=8.2",
-		"typo3/cms-core": "^13.4"
+		"typo3/cms-core": "^13.4",
+		"typo3/cms-extbase": "^13.4"
 	},
 	"require-dev": {
 		"typo3/testing-framework": "^9.0"

Tests/Fixtures/TestExtensions/test_extension/ext_emconf.php

@@ -11,6 +11,7 @@
     'constraints' => [
         'depends' => [
             'typo3' => '11.5.0-11.5.99',
+            'extbase' => '13.4.0-13.4.99',
         ],
         'conflicts' => [],
         'suggests' => [],

Tests/Unit/Domain/Model/ExtensionTest.php

@@ -79,33 +79,41 @@ public function generateSiteSetDefaultValueIsFalse(): void
     /**
      * @test
      */
-    public function getComposerInfoReturnsCorrectConstraintsForV12(): void
+    public function getComposerInfoReturnsCorrectConstraintsForV13(): void
     {
         $this->extension->setExtensionKey('test_extension');
         $this->extension->setVendorName('TestVendor');
-        $this->extension->setTargetVersion(12.4);
+        $this->extension->setTargetVersion(13.4);
 
         $composerInfo = $this->extension->getComposerInfo();
 
-        self::assertSame('>=8.1', $composerInfo['require']['php']);
-        self::assertSame('^12.4', $composerInfo['require']['typo3/cms-core']);
-        self::assertSame('^8.0', $composerInfo['require-dev']['typo3/testing-framework']);
+        self::assertSame('>=8.2', $composerInfo['require']['php']);
+        self::assertSame('^13.4', $composerInfo['require']['typo3/cms-core']);
+        self::assertSame('^13.4', $composerInfo['require']['typo3/cms-extbase']);
+        self::assertSame('^9.0', $composerInfo['require-dev']['typo3/testing-framework']);
     }
 
     /**
      * @test
      */
-    public function getComposerInfoReturnsCorrectConstraintsForV13(): void
+    public function getDependenciesAlwaysContainsExtbase(): void
     {
-        $this->extension->setExtensionKey('test_extension');
-        $this->extension->setVendorName('TestVendor');
-        $this->extension->setTargetVersion(13.4);
+        $dependencies = $this->extension->getDependencies();
 
-        $composerInfo = $this->extension->getComposerInfo();
+        self::assertArrayHasKey('extbase', $dependencies);
+        self::assertSame('13.4.0-13.4.99', $dependencies['extbase']);
+    }
 
-        self::assertSame('>=8.2', $composerInfo['require']['php']);
-        self::assertSame('^13.4', $composerInfo['require']['typo3/cms-core']);
-        self::assertSame('^9.0', $composerInfo['require-dev']['typo3/testing-framework']);
+    /**
+     * @test
+     */
+    public function getDependenciesDoesNotOverrideExistingExtbaseConstraint(): void
+    {
+        $this->extension->setDependencies(['extbase' => '12.0.0-12.4.99']);
+
+        $dependencies = $this->extension->getDependencies();
+
+        self::assertSame('12.0.0-12.4.99', $dependencies['extbase']);
     }
 
     /**
@@ -129,7 +137,6 @@ public function getComposerInfoContainsPhpConstraint(): void
     {
         $this->extension->setExtensionKey('test_extension');
         $this->extension->setVendorName('TestVendor');
-        $this->extension->setTargetVersion(12.4);
 
         $composerInfo = $this->extension->getComposerInfo();