[TASK] Add support for typo3/cms-composer-installers v4 (#595)

Author: derhansen

Classes/Controller/BuilderModuleController.php

@@ -507,11 +507,12 @@ protected function rpcActionSave(): array
         $publicExtensionDirectory = Environment::getExtensionsPath() . '/' . $extension->getExtensionKey();
         $usesComposerPath = $this->extensionService->isComposerStoragePath($extensionDirectory);
         $extensionExistedBefore = is_dir($extensionDirectory);
+        $isComposerInstallerV4 = $this->extensionService->isComposerInstallerV4();
 
         if (!$extensionExistedBefore) {
             GeneralUtility::mkdir($extensionDirectory);
         }
-        if ($usesComposerPath && !is_link($publicExtensionDirectory)) {
+        if ($usesComposerPath && !$isComposerInstallerV4 && !is_link($publicExtensionDirectory)) {
             symlink(
                 PathUtility::getRelativePath(dirname($publicExtensionDirectory), $extensionDirectory),
                 $publicExtensionDirectory
@@ -616,7 +617,7 @@ protected function handleValidationWarnings(array $warnings): array
         $messagesPerErrorCode = [];
         foreach ($warnings as $exception) {
             $errorCode = $exception->getCode();
-            if (!is_array($messagesPerErrorCode[$errorCode])) {
+            if (!isset($messagesPerErrorCode[$errorCode])) {
                 $messagesPerErrorCode[$errorCode] = [];
             }
             $messagesPerErrorCode[$errorCode][] = nl2br(htmlspecialchars($exception->getMessage())) . ' (Error ' . $errorCode . ')<br /><br />';

Classes/Service/ExtensionService.php

@@ -18,6 +18,7 @@
 namespace EBT\ExtensionBuilder\Service;
 
 use TYPO3\CMS\Core\Core\Environment;
+use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\CMS\Core\Utility\PathUtility;
 
 class ExtensionService
@@ -94,4 +95,14 @@ public function isStoragePathConfigured(): bool
     {
         return !Environment::isComposerMode() || count($this->resolveStoragePaths()) > 0;
     }
+
+    /**
+     * Returns, if typo3/cms-composer-installers v4 is used by checking, if /vendor/friendsoftypo3/extension-builder/
+     * is part of the absolute install path of extension_builder
+     */
+    public function isComposerInstallerV4(): bool
+    {
+        $extensionPath = GeneralUtility::getFileAbsFileName('EXT:extension_builder/');
+        return str_contains($extensionPath, '/vendor/friendsoftypo3/extension-builder/');
+    }
 }

Classes/Service/RoundTrip.php

@@ -139,7 +139,7 @@ public function initialize(Extension $extension): void
 
         if (file_exists($this->previousExtensionDirectory . ExtensionBuilderConfigurationManager::EXTENSION_BUILDER_SETTINGS_FILE)) {
             $extensionSchemaBuilder = GeneralUtility::makeInstance(ExtensionSchemaBuilder::class);
-            $jsonConfig = $this->configurationManager->getExtensionBuilderConfiguration($this->previousExtensionKey);
+            $jsonConfig = $this->configurationManager->getExtensionBuilderConfiguration($this->previousExtensionKey, $extension->getStoragePath());
             $this->previousExtension = $extensionSchemaBuilder->build($jsonConfig);
             $previousDomainObjects = $this->previousExtension->getDomainObjects();
             /** @var DomainObject[] $previousDomainObjects */