refactor: polish Information shims and path helpers

Simplify legacy Information re-exports, drop dead code in paths.py,
use prompts_dir consistently in codeql agents, and tighten identity tests.

Author: bx33661

Information/ghsa_fetch.py

@@ -1,10 +1,10 @@
-"""Legacy re-export of ``pure_auto_codeql.information.ghsa_fetch``."""
+"""Legacy re-export of ``pure_auto_codeql.information.ghsa_fetch``.
 
-from pure_auto_codeql.information.ghsa_fetch import *  # noqa: F403
-from pure_auto_codeql.information import ghsa_fetch as _impl
+``from Information import ghsa_fetch`` and ``import Information.ghsa_fetch``
+both resolve to the canonical module object.
+"""
 
-# Preserve module-level identity for ``from Information import ghsa_fetch``
-# callers that access attributes on the submodule.
+from pure_auto_codeql.information import ghsa_fetch as _impl
 import sys as _sys
 
 _sys.modules[__name__] = _impl

Information/nvd_info_fetch.py

@@ -1,8 +1,10 @@
-"""Legacy re-export of ``pure_auto_codeql.information.nvd_info_fetch``."""
+"""Legacy re-export of ``pure_auto_codeql.information.nvd_info_fetch``.
 
-from pure_auto_codeql.information.nvd_info_fetch import *  # noqa: F403
-from pure_auto_codeql.information import nvd_info_fetch as _impl
+``from Information import nvd_info_fetch`` and ``import Information.nvd_info_fetch``
+both resolve to the canonical module object.
+"""
 
+from pure_auto_codeql.information import nvd_info_fetch as _impl
 import sys as _sys
 
 _sys.modules[__name__] = _impl

pure_auto_codeql/agents/codeql_gen_agents/source_sink_fallback_agent.py

@@ -1,7 +1,7 @@
 from pathlib import Path
 from typing import TYPE_CHECKING, Dict, Optional
 
-from pure_auto_codeql.paths import get_repo_root
+from pure_auto_codeql.paths import prompts_dir
 
 if TYPE_CHECKING:
     from dataclasses import dataclass
@@ -26,8 +26,6 @@ def __init__(
     ) -> None:
         self.analyzer = analyzer
         self.language = language or "java"
-
-        self._project_root = get_repo_root()
         self.prompt_file = prompt_file
 
     def _resolve_prompt_path(self, language: Optional[str] = None) -> Path:
@@ -43,8 +41,7 @@ def _resolve_prompt_path(self, language: Optional[str] = None) -> Path:
         }
 
         filename = mapping.get(lang) or mapping["java"]
-        prompts_dir = self._project_root / "prompts"
-        return (prompts_dir / filename).resolve()
+        return (prompts_dir() / filename).resolve()
 
     def _load_prompt(self, language: Optional[str] = None) -> str:
         try:

pure_auto_codeql/agents/codeql_gen_agents/template_refinement_agent.py

@@ -1,7 +1,7 @@
 from pathlib import Path
 from typing import TYPE_CHECKING, Dict, Optional
 
-from pure_auto_codeql.paths import get_repo_root, prompts_dir
+from pure_auto_codeql.paths import prompts_dir
 
 if TYPE_CHECKING:
     from dataclasses import dataclass
@@ -26,8 +26,6 @@ def __init__(
     ) -> None:
         self.analyzer = analyzer
         self.language = language or "java"
-
-        self._project_root = get_repo_root()
         self.prompt_file = prompt_file or (prompts_dir() / "template_refinement.md")
 
     def _load_prompt(self) -> str:
@@ -57,8 +55,7 @@ def _resolve_template_path(self, language: Optional[str] = None) -> Path:
         }
 
         filename = mapping.get(lang) or mapping["java"]
-        prompts_dir = self._project_root / "prompts"
-        return (prompts_dir / filename).resolve()
+        return (prompts_dir() / filename).resolve()
 
     def build_prompt(
         self,

pure_auto_codeql/paths.py

@@ -1,8 +1,8 @@
 """Repository path helpers for PureAutoCodeQL.
 
 Use these instead of hand-counting ``Path(__file__).parent`` hops when
-resolving assets that live at the repository root (prompts/, tools/,
-resources/, projects/, config/). Nested packages under
+resolving assets that live at the repository root (``prompts/``, ``tools/``,
+``resources/``, ``projects/``, ``config/``). Nested packages under
 ``pure_auto_codeql/`` make relative parent walks brittle.
 """
 
@@ -11,26 +11,20 @@
 from functools import lru_cache
 from pathlib import Path
 
-_MARKERS = ("pyproject.toml",)
-
 
 def _looks_like_repo_root(path: Path) -> bool:
-    if not (path / "pyproject.toml").is_file():
-        return False
-    # Prefer a root that still has the runtime asset layout used in-repo.
-    if (path / "prompts").is_dir() or (path / "tools").is_dir():
-        return True
-    return True
+    """True when *path* is the PureAutoCodeQL checkout root."""
+    return (path / "pyproject.toml").is_file()
 
 
 @lru_cache(maxsize=1)
 def get_repo_root() -> Path:
     """Return the repository root directory.
 
     Walks upward from this file until a directory containing
-    ``pyproject.toml`` is found. Falls back to three parents above this
-    module (``pure_auto_codeql/paths.py`` → repo root in the normal
-    checkout layout) if markers are missing (e.g. unusual install).
+    ``pyproject.toml`` is found. Falls back to the parent of the
+    ``pure_auto_codeql`` package (normal checkout layout) if no marker is
+    found (e.g. unusual install layout).
     """
     start = Path(__file__).resolve().parent
     for candidate in (start, *start.parents):

test/test_application_services.py

@@ -112,6 +112,12 @@ def test_canonical_and_legacy_import_surfaces_remain_available():
     assert canonical_ghsa.AdvisoryLookupError is legacy_ghsa.AdvisoryLookupError
     assert canonical_nvd.CveLookupError is legacy_nvd.CveLookupError
 
+    import Information.ghsa_fetch as dotted_ghsa
+    import pure_auto_codeql.information.ghsa_fetch as dotted_canonical_ghsa
+
+    assert dotted_ghsa is dotted_canonical_ghsa
+    assert dotted_ghsa is canonical_ghsa
+
     # Repo root helper resolves real asset layout
     root = get_repo_root()
     assert (root / "pyproject.toml").is_file()