Skip to content

Commit fcecef0

Browse files
committed
update comment
1 parent c904771 commit fcecef0

File tree

1 file changed

+10
-13
lines changed

1 file changed

+10
-13
lines changed

src/file_uploader/s3.rs

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,7 @@ impl S3Client for S3ClientImpl {
2424
async fn new() -> Result<Self, UploadError> {
2525
load_env();
2626

27-
// TODO: load credentials from environment variables
28-
29-
// let credentials = Credentials::new("ACCESS_KEY", "SECRET_KEY", None, None, "custom-provider");
27+
// TODO: verify this locally
3028

3129
let bucket_name = env::var("S3_BUCKET_NAME")
3230
.map_err(|_| UploadError::S3UploadFailed("Missing S3_BUCKET_NAME".to_string()))?;
@@ -35,8 +33,7 @@ impl S3Client for S3ClientImpl {
3533

3634
let shared_config = aws_config::defaults(BehaviorVersion::v2024_03_28())
3735
.region(Region::new(bucket_region))
38-
.profile_name("forcpub")
39-
// .credentials_provider(credentials)
36+
// .profile_name("forcpub")
4037
.load()
4138
.await;
4239
let s3_client = Client::new(&shared_config);
@@ -56,14 +53,14 @@ impl S3Client for S3ClientImpl {
5653
.map_err(|_| UploadError::ReadFile)?;
5754

5855
// Upload to S3
59-
// self.s3_client
60-
// .put_object()
61-
// .bucket(&self.bucket_name)
62-
// .key(&file_name)
63-
// .body(ByteStream::from(buffer))
64-
// .send()
65-
// .await
66-
// .map_err(|e| UploadError::S3UploadFailed(format!("{:?}", e)))?;
56+
self.s3_client
57+
.put_object()
58+
.bucket(&self.bucket_name)
59+
.key(&file_name)
60+
.body(ByteStream::from(buffer))
61+
.send()
62+
.await
63+
.map_err(|e| UploadError::S3UploadFailed(format!("{:?}", e)))?;
6764
Ok(())
6865
}
6966
}

0 commit comments

Comments
 (0)