Skip to content

Commit d303dee

Browse files
committed
No longer deleting WiFi EventGroup when stopping WiFi
This was crashing under certain circumstances. Leaving it alive shouldn't cause issues. Tried switching back and forth between WiFi and BT modes 5 times without incident.
1 parent ccbb292 commit d303dee

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

include/version.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
#define FN_VERSION_MAJOR 0
1111
#define FN_VERSION_MINOR 1
1212

13-
#define FN_VERSION_BUILD "50c31a74"
13+
#define FN_VERSION_BUILD "ccbb292f"
1414

15-
#define FN_VERSION_DATE "2020-09-24 02:16:34"
15+
#define FN_VERSION_DATE "2020-09-24 16:52:25"
1616

17-
#define FN_VERSION_FULL "0.1.50c31a74"
17+
#define FN_VERSION_FULL "0.1.ccbb292f"

lib/hardware/fnWiFi.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,11 @@ void WiFiManager::stop()
4040
ESP_ERROR_CHECK(esp_event_handler_unregister(IP_EVENT, IP_EVENT_STA_GOT_IP, _wifi_event_handler));
4141

4242
// Remove event group
43+
// This is causing a reboot/crash randomly, so we're not going to delete it
44+
/*
4345
if (_wifi_event_group != nullptr)
4446
vEventGroupDelete(_wifi_event_group);
47+
*/
4548

4649
ESP_ERROR_CHECK(esp_wifi_disconnect());
4750
ESP_ERROR_CHECK(esp_wifi_stop());

0 commit comments

Comments
 (0)