SalesTerm XML errors raise verbose IntuitRequestException

Author: mcmire

lib/quickeebooks/online/service/sales_term.rb

@@ -10,6 +10,21 @@ def fetch_by_id(id, idDomain = 'QB', options = {})
           url = "#{url_for_resource(Quickeebooks::Online::Model::SalesTerm::REST_RESOURCE)}/#{id}"
           fetch_object(Quickeebooks::Online::Model::SalesTerm, url, { :idDomain => idDomain })
         end
+
+        private
+
+        def fetch_object(model, url, params = {}, options = {})
+          raise ArgumentError, "missing model to instantiate" if model.nil?
+          response = do_http_get(url, params, {'Content-Type' => 'text/xml'})
+
+          xml = parse_xml(response.body)
+          begin
+            element = xml.at_xpath("//xmlns:#{model::XML_NODE}")
+          rescue Nokogiri::XML::XPath::SyntaxError => ex
+            raise IntuitRequestException.new("Error parsing XML: #{ex.message}\nHTTP Response: (#{response.code}) #{response.body}")
+          end
+          model.from_xml(element)
+        end
       end
     end
   end

lib/quickeebooks/online/service/service_base.rb

@@ -78,17 +78,6 @@ def valid_xml_document(xml)
           %Q{<?xml version="1.0" encoding="utf-8"?>\n#{xml.strip}}
         end
 
-        def fetch_object(model, url, params = {}, options = {})
-          raise ArgumentError, "missing model to instantiate" if model.nil?
-          response = do_http_get(url, params, {'Content-Type' => 'text/xml'})
-
-          xml = parse_xml(response.body)
-          element = xml.at_xpath("//xmlns:#{model::XML_NODE}")
-          model.from_xml(element)
-        rescue => ex
-          raise IntuitRequestException.new("Error parsing XML: #{ex.message}")
-        end
-
         def fetch_collection(model, filters = [], page = 1, per_page = 20, sort = nil, options ={})
           raise ArgumentError, "missing model to instantiate" if model.nil?
 

spec/quickeebooks/online/services/sales_term_spec.rb

@@ -34,4 +34,15 @@
     sales_term.meta_data.last_updated_time.should == Time.parse('2013-01-17T19:04:19-08:00')
     sales_term.name.should == "Net 30"
   end
+
+  context 'when a XML parsing error occurs' do
+    it "raises an IntuitRequestException" do
+      xml = ''
+      url = @service.url_for_resource(Quickeebooks::Online::Model::SalesTerm.resource_for_singular)
+      url = "#{url}/99?idDomain=QB"
+      FakeWeb.register_uri(:get, url, :status => ["200", "OK"], :body => xml)
+      expect{ @service.fetch_by_id(99) }.to raise_error(IntuitRequestException)
+    end
+  end
+
 end