Refactor listener provider system with platform-specific implementations

• Split provider detection logic into platform-specific files using build tags
• Move DetectProvider function from shared provider.go to platform files
• Consolidate TCP provider implementation into provider_other.go
• Add build constraints for darwin (launchd) and linux (systemd) providers
• Remove shared tcp.go file and integrate TCP provider into provider_other.go
• Move syscall utilities to appropriate platform-specific files
• Improve error handling with specific messages when no valid listener detected

Co-authored-by: construct-agent <agent@construct.sh>

Author: Furisto

shared/listener/provider.go

@@ -2,45 +2,10 @@ package listener
 
 import (
 	"net"
-	"runtime"
-	"syscall"
 )
 
 type Provider interface {
 	Create() (net.Listener, error)
 	Close() error
 	ActivationType() string
 }
-
-func DetectProvider(httpAddress, unixSocket string) (Provider, error) {
-	if unixSocket != "" {
-		return NewUnixSocketProvider(unixSocket), nil
-	}
-
-	if httpAddress != "" {
-		return NewTCPListenerProvider(httpAddress), nil
-	}
-
-	switch runtime.GOOS {
-	case "darwin":
-		if IsLaunchdSocketActivation() {
-			return NewLaunchdSocketProvider(), nil
-		}
-	case "linux":
-		if IsSystemdSocketActivation() {
-			return NewSystemdSocketProvider(), nil
-		}
-	}
-
-	return NewTCPListenerProvider("localhost:29333"), nil
-}
-
-func isSocket(fd uintptr) bool {
-	var stat syscall.Stat_t
-	err := syscall.Fstat(int(fd), &stat)
-	if err != nil {
-		return false
-	}
-
-	return stat.Mode&syscall.S_IFMT == syscall.S_IFSOCK
-}

shared/listener/provider_launchd.go

@@ -1,3 +1,5 @@
+//go:build darwin
+
 package listener
 
 import (
@@ -35,3 +37,19 @@ func (p *LaunchdSocketProvider) ActivationType() string {
 func IsLaunchdSocketActivation() bool {
 	return strings.HasPrefix(os.Getenv("XPC_SERVICE_NAME"), "sh.construct.daemon.")
 }
+
+func DetectProvider(httpAddress, unixSocket string) (Provider, error) {
+	if unixSocket != "" {
+		return NewUnixSocketProvider(unixSocket), nil
+	}
+
+	if httpAddress != "" {
+		return NewTCPListenerProvider(httpAddress), nil
+	}
+
+	if IsLaunchdSocketActivation() {
+		return NewLaunchdSocketProvider(), nil
+	}
+
+	return nil, fmt.Errorf("no valid listener has been detected. Specify either a unix socket, tcp address or use launchd socket activation")
+}

shared/listener/provider_unix.go shared/listener/provider_other.goshared/listener/provider_unix.go renamed to shared/listener/provider_other.go

@@ -45,3 +45,34 @@ func (p *UnixSocketProvider) Close() error {
 func (p *UnixSocketProvider) ActivationType() string {
 	return "unix"
 }
+
+
+type TCPProvider struct {
+	httpAddress string
+}
+
+var _ Provider = (*TCPProvider)(nil)
+
+func NewTCPListenerProvider(httpAddress string) *TCPProvider {
+	return &TCPProvider{
+		httpAddress: httpAddress,
+	}
+}
+
+func (p *TCPProvider) Create() (net.Listener, error) {
+	listener, err := net.Listen("tcp", p.httpAddress)
+	if err != nil {
+		return nil, fmt.Errorf("failed to listen on tcp: %w", err)
+	}
+
+	return listener, nil
+}
+
+func (p *TCPProvider) Close() error {
+	return nil
+}
+
+func (p *TCPProvider) ActivationType() string {
+	return "tcp"
+}
+

shared/listener/provider_systemd.go

@@ -1,10 +1,14 @@
+//go:build linux
+
 package listener
 
 import (
 	"fmt"
 	"net"
 	"os"
 	"strconv"
+
+	"syscall"
 )
 
 const systemdSocketFD = 3
@@ -66,3 +70,29 @@ func IsSystemdSocketActivation() bool {
 
 	return false
 }
+
+func isSocket(fd uintptr) bool {
+	var stat syscall.Stat_t
+	err := syscall.Fstat(int(fd), &stat)
+	if err != nil {
+		return false
+	}
+
+	return stat.Mode&syscall.S_IFMT == syscall.S_IFSOCK
+}
+
+func DetectProvider(httpAddress, unixSocket string) (Provider, error) {
+	if unixSocket != "" {
+		return NewUnixSocketProvider(unixSocket), nil
+	}
+
+	if httpAddress != "" {
+		return NewTCPListenerProvider(httpAddress), nil
+	}
+
+	if IsSystemdSocketActivation() {
+		return NewSystemdSocketProvider(), nil
+	}
+
+	return nil, fmt.Errorf("no valid listener has been detected. Specify either a unix socket, tcp address or use systemd socket activation")
+}