Fix exit node selection to read annotation from service instead of exit node

- Changed logic to check Service annotations for exit-node-name instead of ExitNode annotations
- Added parsing of namespace/name format using parse_provisioner_label_value
- Added tests to validate the parse_provisioner_label_value function
- All tests pass and clippy runs clean

Co-authored-by: korewaChino <[email protected]>

Author: Copilot

src/daemon.rs

@@ -474,14 +474,24 @@ async fn reconcile_svcs(obj: Arc<Service>, ctx: Arc<Context>) -> Result<Action,
 
     let node_list = nodes.list(&ListParams::default().timeout(30)).await?;
 
-    // Find service binding of svc name/namespace?
-    let named_exit_node = node_list.iter().find(|node| {
-        node.metadata
-            .annotations
-            .as_ref()
-            .map(|annotations| annotations.contains_key(EXIT_NODE_NAME_LABEL))
-            .unwrap_or(false)
-    });
+    // Check if service has explicitly set an exit node name
+    let named_exit_node = obj
+        .metadata
+        .annotations
+        .as_ref()
+        .and_then(|annotations| annotations.get(EXIT_NODE_NAME_LABEL))
+        .and_then(|exit_node_name| {
+            // Parse the exit node name, which can be in the format "namespace/name" or just "name"
+            let service_namespace = obj.namespace().unwrap();
+            let (target_namespace, target_name) =
+                parse_provisioner_label_value(&service_namespace, exit_node_name);
+
+            // Find the exit node with the matching name and namespace
+            node_list.iter().find(|node| {
+                node.metadata.name.as_deref() == Some(target_name)
+                    && node.metadata.namespace.as_deref() == Some(target_namespace)
+            })
+        });
 
     // XXX: Exit node manifest generation starts here
     let node = {

src/ops.rs

@@ -237,3 +237,29 @@ impl ExitNodeProvisioner {
         Ok(Some(secret))
     }
 }
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    #[test]
+    fn test_parse_provisioner_label_value_with_namespace() {
+        let (namespace, name) = parse_provisioner_label_value("default", "kube-system/cappy-chisel");
+        assert_eq!(namespace, "kube-system");
+        assert_eq!(name, "cappy-chisel");
+    }
+
+    #[test]
+    fn test_parse_provisioner_label_value_without_namespace() {
+        let (namespace, name) = parse_provisioner_label_value("default", "cappy-chisel");
+        assert_eq!(namespace, "default");
+        assert_eq!(name, "cappy-chisel");
+    }
+
+    #[test]
+    fn test_parse_provisioner_label_value_with_different_default_namespace() {
+        let (namespace, name) = parse_provisioner_label_value("my-namespace", "exit-node-1");
+        assert_eq!(namespace, "my-namespace");
+        assert_eq!(name, "exit-node-1");
+    }
+}