fix gh login without name attr

Author: lebalz

README.md

@@ -300,7 +300,11 @@ dokku letsencrypt:enable dev-teaching-api
 ```bash
 # inside shell of VSCode DevContainer (with configured dokku git remote)
 dokku postgres:export dev-teaching-api > tdev-backup.dump
+psql -U postgres -h localhost -c 'drop database if exists teaching_api;'
+psql -U postgres -h localhost -c 'create database teaching_api;'
 pg_restore -h localhost --verbose --clean --no-owner --no-privileges -U postgres -d teaching_api < tdev-backup.dump
+yarn run prisma migrate dev
+
 # when ai-pr was once merged/deployed to the db, run `delete from _prisma_migrations where migration_name ilike '%_ai_%';`
 ```
 

src/auth.ts

@@ -4,7 +4,7 @@ import prisma from './prisma';
 import { admin, createAuthMiddleware, oneTimeToken } from 'better-auth/plugins';
 import { CORS_ORIGIN_STRINGIFIED } from './utils/originConfig';
 import { getNameFromEmail } from './helpers/email';
-import type { MicrosoftEntraIDProfile } from 'better-auth/social-providers';
+import type { GithubProfile, MicrosoftEntraIDProfile } from 'better-auth/social-providers';
 import Logger from './utils/logger';
 import { getIo, notify } from './socketIoServer';
 import User from './models/User';
@@ -27,6 +27,19 @@ const getNameFromMsftProfile = (profile: MicrosoftEntraIDProfile) => {
     return getNameFromEmail(profile.email || profile.preferred_username);
 };
 
+const getNameFromGithubProfile = (profile: GithubProfile) => {
+    if (profile.name) {
+        const parts = profile.name.split(', ')[0]?.split(' ') || [];
+        if (parts.length > 1) {
+            const firstName = parts.pop()!;
+            const lastName = parts.join(' ');
+            return { firstName, lastName };
+        }
+    }
+    const { firstName, lastName } = getNameFromEmail(profile.email);
+    return { firstName: firstName ?? profile.login, lastName: lastName ?? profile.login };
+};
+
 const HAS_PROVIDER_GH = !!process.env.BETTER_AUTH_GITHUB_ID && !!process.env.BETTER_AUTH_GITHUB_SECRET;
 const HAS_PROVIDER_MSFT = !!process.env.MSAL_CLIENT_ID && !!process.env.MSAL_CLIENT_SECRET;
 
@@ -60,11 +73,11 @@ export const auth = betterAuth({
                       clientId: process.env.BETTER_AUTH_GITHUB_ID!,
                       clientSecret: process.env.BETTER_AUTH_GITHUB_SECRET!,
                       mapProfileToUser: (profile) => {
-                          const [firstName, lastName] = profile.name.split(' ');
+                          const name = getNameFromGithubProfile(profile);
                           return {
                               ...profile,
-                              firstName: firstName || '',
-                              lastName: lastName || ''
+                              firstName: name.firstName || '',
+                              lastName: name.lastName || ''
                           };
                       }
                   }