Fix format on save ignored directories path matching logic (#325)

* fix(plugin): resolve ignored directories never matching due to trailing slash

Fixes a bug introduced in #191

Directory paths with a trailing "/" (e.g. "addons/") would produce
a trailing empty string when split on "/", which could never match
a real path segment. This silently broke the ignore rule for any
entry with a trailing slash.

This fix trims the trailing "/" before splitting.

* fix(plugin): resolve out-of-bounds access when ignored directory is deeper than script path

Fixes a bug introduced in #191

The matching loop indexed script_path_parts[i] using the length of
directory_parts, without checking that directory_parts wasn't longer.
If an ignored directory's path has more segments than the script's
path, and every one of those extra segments follows a full match of
the script's path, the loop runs past the end of script_path_parts.

Example: script at "res://addons/foo.gd" (script_path_parts =
["addons", "foo.gd"]) checked against ignored directory
"addons/foo.gd/bar" (directory_parts = ["addons", "foo.gd", "bar"]).
The first two segments match, then the loop tries to read
script_path_parts[2], which doesn't exist.

Skip directories that have more segments than the script path, since
they can never match as a prefix.

* fix(plugin): skip and warn on blank format on save ignored directories entries

Fixes a bug introduced in #191

An ignored directory entry that is blank, "res://", or just "/" would
normalize to an empty string. Splitting that on "/" produces [""],
which could be compared against script path segments in unintended
ways instead of being treated as an invalid entry.

Skip these entries and push a warning so users know the entry has no usable path and needs to be removed or corrected.
Also warns the user that if the intention was to ignore the whole project that this is not supported here and they need to turn of format on save instead.

* fix(plugin): warn on format on save ignored directories entries that duplicate an earlier entry after normalization

Fixes a bug introduced in #191

The Format on Save Ignored Directories list was not checked for entries that normalize
to the same path despite being written differently (e.g. "res://addons" and "addons/").
This could let redundant entries sit in the list unnoticed.

Track each normalized entry as it's validated, and if a later entry normalizes to the same as one already seen,
skip it and push a warning naming both the duplicate and the original entry it conflicts with.

* refactor: trim comments, rename variables

---------

Co-authored-by: Nathan Lovato <12694995+NathanLovato@users.noreply.github.com>

Author: NoahGreer

addons/GDQuest_GDScript_formatter/plugin.gd

@@ -173,7 +173,7 @@ func _enter_tree() -> void:
 	installer = FormatterInstaller.new(formatter_cache_dir)
 	add_child(installer)
 	installer.installation_completed.connect(
-		func _on_installation_completed (binary_path: String) -> void:
+		func _on_installation_completed(binary_path: String) -> void:
 			set_editor_setting(SETTING_FORMATTER_PATH, binary_path)
 			_has_formatter_command = has_command(binary_path)
 			if not _has_formatter_command:
@@ -188,7 +188,7 @@ func _enter_tree() -> void:
 				menu.update_menu(true),
 	)
 	installer.installation_failed.connect(
-		func _on_installation_failed (error_message: String) -> void:
+		func _on_installation_failed(error_message: String) -> void:
 			push_error("Formatter installation failed: ", error_message),
 	)
 
@@ -347,18 +347,42 @@ func _on_resource_saved(saved_resource: Resource) -> void:
 	if not do_format_on_save and not lint_on_save:
 		return
 
-	var ignored_directories = get_editor_setting(SETTING_IGNORED_DIRECTORIES)
-	var path = script.resource_path.trim_prefix("res://")
+	var ignored_directories_normalized: Array[String] = []
+	var ignored_directories_seen: Dictionary[String, String] = { }
+	for directory: String in get_editor_setting(SETTING_IGNORED_DIRECTORIES):
+		# We split paths on "/", we trim trailing slashes to avoid empty path
+		# segments that would never match when checking ignored directories.
+		var directory_normalized := directory.trim_prefix("res://").trim_suffix("/")
+		if directory_normalized.is_empty():
+			push_warning(
+				"GDScript Formatter: Format on Save Ignored Directories entry \"%s\" " % directory
+				+ "has no path after removing \"res://\" and trailing slashes, and will be skipped. "
+				+ "This may mean you're trying to ignore the entire project, which isn't supported here. "
+				+ "Please remove it from the list, enter a valid path, or turn off format on save instead."
+			)
+			continue
+
+		if ignored_directories_seen.has(directory_normalized):
+			push_warning(
+				"GDScript Formatter: Format on Save Ignored Directories entry \"%s\" " % directory
+				+ "refers to the same directory as entry \"%s\" "
+				% ignored_directories_seen[directory_normalized]
+				+ "and will be skipped. Please remove the duplicate entry from the list."
+			)
+			continue
 
-	var script_path_parts := path.split("/")
+		ignored_directories_seen[directory_normalized] = directory
+		ignored_directories_normalized.push_back(directory_normalized)
 
-	for directory: String in ignored_directories:
-		var normalized_dir := directory.trim_prefix("res://")
-		var directory_parts := normalized_dir.split("/")
+	var saved_script_path_segments := script.resource_path.trim_prefix("res://").split("/")
+	for ignored_directory_path: String in ignored_directories_normalized:
+		var ignored_directory_segments := ignored_directory_path.split("/")
+		if ignored_directory_segments.size() > saved_script_path_segments.size():
+			continue
 
 		var matches := true
-		for i in range(directory_parts.size()):
-			if directory_parts[i] != script_path_parts[i]:
+		for i in range(ignored_directory_segments.size()):
+			if ignored_directory_segments[i] != saved_script_path_segments[i]:
 				matches = false
 				break