`type:layer` location entry with lookup layer, featureLookup, and changeEnd

[simon-leech]

I have a type:layer with this configuration.

 {
      "name": "A",
      "type": "layer",
      "featureLookup": true,
      "zIndex": 98,
      "layer": "layer_to_copy",
      "query": "query_to_run",
      "template": {
        "key": "query_to_run",
        "src": "whatever"
      },
      "queryparams": {
        "id": true,
        "table": "schema.table"
      }
    }

The layer is correctly cloned and the initial theme is shown on the map.

However:

1. changing the labels on the type: layer clone is not working.
2. changing the theme on the type:layer clone is not working properly - some of the themes aren't styling but work correctly on the non-cloned version of the llayer.
3. changing the theme is not changing the hover as it should.

[simon-leech]

On testing this, it looks like it is applied but the layer isn't reloaded correctly or something.

If I toggle a label and then zoom in or pan it appears on the map, so it's like the reload isn't working

[dbauszus-glx]

The reason for the configuration not working is due to the featureLookup logic for MVT layer.

The layer configuration is cloned and assigned to the layer entry from the locale.layers list. The MVT layer reload will only query geometries without properties with the 'featureLookup' flag. The properties will be queried and assigned from the layer entry query. This query is missing the properties for the label and some of the themes hence the featureStyle method is not able to style features according to the style config.

A 'featureSet' config with a query returning an array of feature ID should be used to ensure that the clone style configuration is working with the MVT format.

There are however a few issues which I address in the linked PR. The assignment of the locale layer JSON should not return from the entry method if the layer isn't found in the mapview list. The assignment should be handled in a method rather than an if block.

layer.changeEnd methods for location entries should be removed from the mapview.changeEndCallbacks array.