Skip to content

Commit 0585d92

Browse files
committed
Copilot comments
1 parent 0936004 commit 0585d92

4 files changed

Lines changed: 11 additions & 5 deletions

File tree

inputFiles/singlePhaseWell/singlePhaseWell.ats

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ decks = [
6060
restartcheck_params=RestartcheckParameters(**restartcheck_params)),
6161
TestDeck(
6262
name="thermal_compressible_single_phase_wells_1d",
63-
description='Thermal well test (1D, thermal, 1 wells)',
63+
description='Thermal well test (1D, thermal, 1 well)',
6464
partitions=((1, 1, 1),),
6565
restart_step=10,
6666
check_step=10,

src/coreComponents/constitutive/thermalConductivity/SinglePhaseThermalConductivity.cpp

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -138,9 +138,13 @@ void SinglePhaseThermalConductivity::initializeState( localIndex const size ) co
138138
{
139139
for( localIndex q = 0; q < numQuad; ++q )
140140
{
141-
referenceThermalConductivity[ei][q][0] = defaultThermalConductivityComponents[0];
142-
referenceThermalConductivity[ei][q][1] = defaultThermalConductivityComponents[1];
143-
referenceThermalConductivity[ei][q][2] = defaultThermalConductivityComponents[2];
141+
for( integer dim=0; dim < 3; ++dim )
142+
{
143+
if( referenceThermalConductivity[ei][q][dim] < 0 )
144+
{
145+
referenceThermalConductivity[ei][q][dim] = defaultThermalConductivityComponents[dim];
146+
}
147+
}
144148
}
145149
} );
146150
}

src/coreComponents/constitutive/thermalConductivity/SinglePhaseThermalConductivityBase.hpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,9 @@ class SinglePhaseThermalConductivityBaseUpdate
5555

5656
/**
5757
* @brief Constructor for the class performing the thermal conductivity updates
58+
* @param referenceThermalConductivity the array of cell-wise reference conductivities in the subregion
5859
* @param effectiveConductivity the array of cell-wise effective conductivities in the subregion
60+
* @param dEffectiveConductivity_dT the array of cell-wise derivatives of the effective conductivities w.r.t. temperature in the subregion
5961
*/
6062
SinglePhaseThermalConductivityBaseUpdate( arrayView3d< real64 > const & referenceThermalConductivity,
6163
arrayView3d< real64 > const & effectiveConductivity,

src/coreComponents/physicsSolvers/surfaceGeneration/EmbeddedSurfaceGenerator.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,7 @@ real64 EmbeddedSurfaceGenerator::solverStep( real64 const & GEOS_UNUSED_PARAM( t
288288
string const thermalCondModelName = getConstitutiveName< SinglePhaseThermalConductivityBase >( fractureSubRegion );
289289
if( !thermalCondModelName.empty() )
290290
{
291-
// if a thermal conductivity model exists we need to set the intial value to something meaningful
291+
// if a thermal conductivity model exists we need to set the initial value to something meaningful
292292
SinglePhaseThermalConductivityBase & thermalCondModel = getConstitutiveModel< SinglePhaseThermalConductivityBase >( fractureSubRegion, thermalCondModelName );
293293
thermalCondModel.initializeState();
294294
}

0 commit comments

Comments
 (0)