RDF 1.4.2

Author: ccenotti

docs/specification.md

@@ -9,7 +9,7 @@ RDF files are structured as following:
 
 All offsets are relative to the file start. All sizes are in bytes. There is no requirement to put the chunk index at the end, but it's convenient for tools which generate RDF files so we expect the index to be at the end. Structures are assumed to be "C" packed.
 
-*must*, *should*, etc. is used in accordance with [RFC 2119](https://datatracker.ietf.org/doc/html/rfc2119)
+*must*, *should*, etc. is used in accordance with RFC 2119.
 
 ![RDF overview](rdf.svg)
 

rdf/inc/amdrdf.h

@@ -26,7 +26,7 @@
      (static_cast<std::uint32_t>(minor) << 12) | \
      (static_cast<std::uint32_t>(patch)))
 
-#define RDF_INTERFACE_VERSION RDF_MAKE_VERSION(1, 3, 0)
+#define RDF_INTERFACE_VERSION RDF_MAKE_VERSION(1, 4, 0)
 
 extern "C" {
 struct rdfChunkFile;

rdf/src/amdrdf.cpp

@@ -57,7 +57,8 @@ namespace internal
     */
     bool CheckIsInSystemSizeRange(std::int64_t v)
     {
-        if (sizeof(size_t) == 4) {
+        constexpr bool size_t_is_4 = sizeof(size_t) == 4;
+        if (size_t_is_4) {
             return v <= static_cast<std::int64_t>(std::numeric_limits<std::uint32_t>::max());
         }
 
@@ -972,6 +973,9 @@ namespace internal
         std::int64_t WriteImpl(const std::int64_t offset,
             const std::int64_t count, const void* buffer) override
         {
+            (void)offset;
+            (void)count;
+            (void)buffer;
             assert(false);
             return 0;
         }