Skip to content

[Bug]: AMF FRC doesn't recover after Drain, SubmitInput() returns AMF_EOF. #581

@kasper93

Description

@kasper93

To reproduce

  1. Call AMFComponent::Drain()
  2. Call AMFComponent::QueryOutput() until AMF_EOF is returned.
  3. Call AMFComponent::SubmitInput()

At this point the AMFComponent::SubmitInput() will keep returning AMF_EOF. This can be recovered by AMFComponent::ReInit(), but this is not what documentation says.

In AMFComponent::QueryOutput() we can read:

When draining has been initiated (see AMFComponent::Drain for more detail) and the last output sample has been retrieved, QueryOutput returns AMF_EOF. This indicates the end of the drain operation, after which input samples can continue to be submitted.

In AMFComponent::SubmitInput() we can read:

AMF_INPUT_FULL when the output is not properly drained

and we see that AMF_EOF is not documented to be valid return value from submit.

My understanding is that after draining completes, there shouldn't be a need to call reinit, and SubmitInput() shouldn't return AMF_EOF, as it makes little sense.

Thanks,
Kacper

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions