Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Commit 9128271

Browse files
author
Courtney Brousseau
authored
Merge pull request #226 from GSA/cb-google-analytics-fix
Fix google tag manager issue
2 parents 42be7e4 + 7f22a09 commit 9128271

4 files changed

Lines changed: 55 additions & 61 deletions

File tree

.DS_Store

8 KB
Binary file not shown.

config/webpack/webpack.shared.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ const nodeModulesDir = join(rootDir, 'node_modules')
1616

1717
console.log('process.env.CODE_GOV_API_BASE:', process.env.CODE_GOV_API_BASE)
1818
console.log('process.env.CODE_GOV_API_KEY:', process.env.CODE_GOV_API_KEY)
19+
console.log('process.env.CODE_GOV_BRANCH:', process.env.CODE_GOV_BRANCH)
20+
console.log('process.env.CODE_GOV_RELATIVE_DIR:', process.env.CODE_GOV_RELATIVE_DIR)
1921

2022
// https://webpack.js.org/guides/public-path/
2123
const PUBLIC_PATH = process.env.PUBLIC_PATH || '/';
@@ -203,7 +205,7 @@ module.exports = {
203205
}
204206
}),
205207
new DefinePlugin({
206-
'ENABLE_GOOGLE_ANALYTICS': JSON.stringify(process.env.CODE_GOV_BRANCH === 'federalist-prod'),
208+
'ENABLE_GOOGLE_ANALYTICS': process.env.CODE_GOV_BRANCH === 'federalist-prod',
207209
'PUBLIC_PATH': JSON.stringify(PUBLIC_PATH),
208210
'SITE_CONFIG': JSON.stringify(SITE_CONFIG)
209211
}),

package-lock.json

Lines changed: 50 additions & 58 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,14 +89,14 @@
8989
"recompose": "^0.30.0",
9090
"redux": "^4.0.1",
9191
"redux-thunk": "^2.3.0",
92+
"snyk": "^1.174.2",
9293
"url-search-params-polyfill": "^5.1.0",
9394
"webpack-bundle-analyzer": "^3.3.2",
9495
"webpack-cli": "^3.3.2",
9596
"webpack-create-file-plugin": "^1.0.0",
9697
"webpack-dev-server": "^3.3.1",
9798
"webpack-merge": "^4.2.1",
98-
"whatwg-fetch": "^3.0.0",
99-
"snyk": "^1.171.0"
99+
"whatwg-fetch": "^3.0.0"
100100
},
101101
"devDependencies": {
102102
"@babel/core": "^7.4.4",

0 commit comments

Comments
 (0)