Skip to content

Full Review for all tasks #55

@nada-abuzaid

Description

@nada-abuzaid

Notes

  • Move assets folder to public folder and update the images paths.
  • In the styled, if u don't use the theme, u don't need to add function, take a look to basic usage.
  • Please take care from spaces between codes!
  • Delete any empty file src/components/Charts/charts.styled.tsx.
  • We already inside the pages folder, so no need to name pages as homePage, .. etc
  • Delete any unused files src/interfaces/userData.ts, src/components/Common/Text.tsx, src/components/EditTask/index.tsx
  • Don't write any color code, use the theme and if the color doesn't exist, please add it to our theme and custom interface and use it. src/components/Signup/signup.styled.tsx
  • Delete AppBar component, and add the useCard to the Sidebar.
  • Split your Logo in separate component.
  • Update all font family.
  • Delete utils folder.
  • Fix Login and Signup style.
  • In each file, we use Axios and send requests to the API and got data or error, do you think it is the best way to handle the requests? in each file, you import Axios and create a state and use useEffect to send the request, and set the loading status .. etc. what about custom hooks? Read more.
  • Read about react-query
  • React.FC is not the preferable way to type a React component, here's a Remove React.FC from Typescript template facebook/create-react-app#8177.

The use of React.FC in TypeScript templates has been a common practice to define functional components in React. However, starting from React 17, the use of React.FC has been discouraged in favor of a more specific type declaration.

The main reason behind this deprecation is related to the issue of defaultProps. With React.FC, the defaultProps are automatically inferred as optional properties on the functional component, which can lead to unintended behavior. This is because defaultProps should be treated as required properties, not optional ones.

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingenhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions