Skip to content

Consolidate GUI styling/colors and move domain types to api - #5

Merged
tier940 merged 5 commits into
mainfrom
tier-api-refactoring
Jun 20, 2026
Merged

Consolidate GUI styling/colors and move domain types to api#5
tier940 merged 5 commits into
mainfrom
tier-api-refactoring

Conversation

@tier940

@tier940 tier940 commented Jun 20, 2026

Copy link
Copy Markdown
Member

No description provided.

@tier940 tier940 self-assigned this Jun 20, 2026
@tier940

tier940 commented Jun 20, 2026

Copy link
Copy Markdown
Member Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the build system to RetroFuturaGradle 2.x and Gradle 9.2.0, reorganizes the package structure to expose a public API surface (including a central BLPCAPI façade), refactors the network layer, and refines the party UI and JourneyMap integration. The code review identified a critical compilation error in BLPCSaveHandler due to missing imports, as well as several potential NullPointerException risks in PartyWidgets, Party, PartyProviderRegistry, PartyQueryUtil, and MembersPanel where null checks are missing.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +240 to +242
try {
Files.move(tmp.toPath(), finalFile.toPath(), StandardCopyOption.REPLACE_EXISTING);
} catch (IOException e) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The classes Files and StandardCopyOption are used here but are not imported in this file, which will cause a compilation error. Since we cannot easily add imports outside the modified diff hunks, please use their fully qualified names to ensure the code compiles successfully.

Suggested change
try {
Files.move(tmp.toPath(), finalFile.toPath(), StandardCopyOption.REPLACE_EXISTING);
} catch (IOException e) {
try {
java.nio.file.Files.move(tmp.toPath(), finalFile.toPath(), java.nio.file.StandardCopyOption.REPLACE_EXISTING);
} catch (IOException e) {

Comment thread src/main/java/com/github/gtexpert/blpc/api/party/Party.java
Comment thread src/main/java/com/github/gtexpert/blpc/api/util/PartyQueryUtil.java Outdated
@tier940
tier940 merged commit 55fc008 into main Jun 20, 2026
4 checks passed
@tier940
tier940 deleted the tier-api-refactoring branch June 20, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant