change base notification to protocol

Author: GabrielSalla

src/notifications/base_notification.py

@@ -1,14 +1,9 @@
-from dataclasses import dataclass
 from functools import partial
-from typing import Coroutine
+from typing import Coroutine, Protocol, runtime_checkable
 
-from dataclass_type_validator import dataclass_validate
 
-
-@dataclass_validate(strict=True)
-@dataclass
-class BaseNotification:
+@runtime_checkable
+class BaseNotification(Protocol):
     min_priority_to_send: int = 5
 
-    def reactions_list(self) -> list[tuple[str, list[Coroutine | partial[Coroutine]]]]:
-        return []  # pragma: no cover
+    def reactions_list(self) -> list[tuple[str, list[Coroutine | partial[Coroutine]]]]: ...

src/plugins/slack/notifications/slack_notification.py

@@ -10,7 +10,6 @@
 
 from configs import configs
 from models import Alert, AlertPriority, AlertStatus, Issue, IssueStatus, Monitor, Notification
-from notifications.base_notification import BaseNotification
 
 from .. import slack
 
@@ -33,7 +32,7 @@
 
 @dataclass_validate(strict=True)
 @dataclass(kw_only=True)
-class SlackNotification(BaseNotification):
+class SlackNotification:
     """
     The **SlackNotification** class manages sending notifications for alerts to a specified Slack
     channel.

tests/components/monitors_loader/test_monitors_loader.py

@@ -11,7 +11,6 @@
 import utils.time as time_utils
 from configs import configs
 from models import CodeModule, Monitor
-from notifications import BaseNotification
 from options import ReactionOptions
 from registry import registry
 from tests.test_utils import assert_message_in_log
@@ -454,7 +453,9 @@ async def test_configure_monitor_notifications_setup(monkeypatch, sample_monitor
 
     async def do_nothing(): ...
 
-    class MockNotification(BaseNotification):
+    class MockNotification:
+        min_priority_to_send = 5
+
         def reactions_list(self):
             return [
                 ("alert_updated", [do_nothing]),

tests/module_loader/test_checker.py

@@ -1,11 +1,10 @@
 from types import ModuleType
-from typing import TypedDict
+from typing import Coroutine, TypedDict
 from unittest.mock import MagicMock
 
 import pytest
 
 import module_loader.checker as checker
-from notifications import BaseNotification
 from options import (
     AlertOptions,
     CountRule,
@@ -256,6 +255,13 @@ def test_check_reaction_options_wrong_type(monitor_mock):
 
 # Test _check_notification_options
 
+class BaseNotification:
+    """Notification class to be used in the tests"""
+    min_priority_to_send: int = 5
+
+    def reactions_list(self) -> list[tuple[str, list[Coroutine]]]:
+        return []
+
 
 def test_check_notification_options_defined(monitor_mock):
     """'_check_notification_options' should return no erros if the 'notification_options' field is

tests/notifications/test_base_notification.py

@@ -0,0 +1,5 @@
+from notifications.base_notification import BaseNotification
+
+
+def test_base_notification():
+    assert BaseNotification.min_priority_to_send == 5

tests/plugins/slack/actions/test_actions.py

@@ -2,9 +2,9 @@
 
 import pytest
 
-import registry as registry
 import plugins.slack.actions.actions as actions
 import plugins.slack.notifications.slack_notification as slack_notification
+import registry as registry
 from models import Alert, Monitor, Notification, NotificationStatus
 from tests.test_utils import assert_message_in_log