Merge pull request #120 from GabrielSalla/create-alert-interaction-options-methods

create alert methods for interaction options

Author: GabrielSalla

src/models/alert.py

@@ -64,6 +64,16 @@ def is_priority_acknowledged(self) -> bool:
             return False
         return self.acknowledge_priority <= self.priority
 
+    @property
+    def can_acknowledge(self) -> bool:
+        """Check if the alert can be acknowledged"""
+        return not self.is_priority_acknowledged
+
+    @property
+    def can_lock(self) -> bool:
+        """Check if the alert can be locked"""
+        return not self.locked
+
     @staticmethod
     def calculate_priority(
         rule: AgeRule | CountRule | ValueRule, issues: list[Issue] | Sequence[Issue]

src/plugins/slack/notifications/slack_notification.py

@@ -224,13 +224,13 @@ async def _build_notification_buttons(
     if alert.status == AlertStatus.solved:
         return buttons
 
-    if not alert.is_priority_acknowledged:
+    if alert.can_acknowledge:
         buttons.append(
             slack.MessageButton(
                 text="Ack", action_id=f"sentinela_ack_{alert.id}", value=f"ack {alert.id}"
             )
         )
-    if not alert.locked:
+    if alert.can_lock:
         buttons.append(
             slack.MessageButton(
                 text="Lock", action_id=f"sentinela_lock_{alert.id}", value=f"lock {alert.id}"

tests/models/test_alert.py

@@ -116,7 +116,48 @@ async def test_is_priority_acknowledged(
         priority=priority,
     )
 
-    assert alert.is_priority_acknowledged == expected_result
+    assert alert.is_priority_acknowledged is expected_result
+
+
+@pytest.mark.parametrize(
+    "acknowledged, acknowledge_priority, priority, expected_result",
+    [
+        (False, 1, 1, True),
+        (False, 1, 5, True),
+        (False, 5, 1, True),
+        (False, None, 1, True),
+        (True, 5, 1, True),
+        (True, 5, 4, True),
+        (True, 5, 5, False),
+        (True, 2, 1, True),
+        (True, 1, 1, False),
+        (True, 1, 5, False),
+        (True, 1, 2, False),
+        (True, None, 1, True),
+    ],
+)
+async def test_can_acknowledge(
+    sample_monitor: Monitor, acknowledged, acknowledge_priority, priority, expected_result
+):
+    """'Alert.can_acknowledge' should return 'True' if the current alert can be acknowledged,
+    'False' otherwise"""
+    alert = await Alert.create(
+        monitor_id=sample_monitor.id,
+        acknowledged=acknowledged,
+        acknowledge_priority=acknowledge_priority,
+        priority=priority,
+    )
+
+    assert alert.can_acknowledge is expected_result
+
+
+@pytest.mark.parametrize("locked", [False, True])
+async def test_can_lock(sample_monitor: Monitor, locked):
+    """'Alert.can_lock' should return 'True' if the current alert can be locked, 'False'
+    otherwise"""
+    alert = await Alert.create(monitor_id=sample_monitor.id, locked=locked)
+
+    assert alert.can_lock is not locked
 
 
 async def test_calculate_priority(mocker, sample_monitor: Monitor):