Merge pull request #71 from GabrielSalla/add-module-load-tests

Add load module from file reload tests

Author: GabrielSalla

tests/module_loader/test_loader.py

@@ -134,10 +134,11 @@ def test_load_module_from_file(caplog):
         (10, 200),
     ],
 )
-def test_load_module_from_file_reload(caplog, n1, n2):
+def test_load_module_from_file_reload_sleep(caplog, n1, n2):
     """'load_module_from_file' should be able to reload modules that were previously loaded,
-    allowing hot changes"""
-    module_name = f"load_module_from_file_reload_{n1}_{n2}"
+    allowing hot changes. To be able reload a file the file timestamp or size must change, or the
+    cache must be invalidated"""
+    module_name = f"test_load_module_from_file_reload_sleep_{n1}_{n2}"
     module_code = "def get_value(): return {n}"
 
     module_path = loader.create_module_files(module_name, module_code.format(n=n1))
@@ -147,8 +148,8 @@ def test_load_module_from_file_reload(caplog, n1, n2):
     assert module.get_value() == n1
     assert_message_in_log(caplog, f"Monitor '{module_name}' loaded")
 
-    # As python checks for the timestamp to change to reload a module, sleep for 1 second
-    time.sleep(1)
+    # Sleep until next second
+    time.sleep(1 - time.time() % 1 + 0.01)
 
     module_path = loader.create_module_files(module_name, module_code.format(n=n2))
 
@@ -158,6 +159,31 @@ def test_load_module_from_file_reload(caplog, n1, n2):
     assert_message_in_log(caplog, f"Monitor '{module_name}' loaded", count=2)
 
 
+@pytest.mark.flaky(reruns=1)
+def test_load_module_from_file_reload_no_time_change(caplog):
+    """'load_module_from_file' should not reload the file if the file timestamp or size didn't
+    change. Test is marked with 'flaky' because the second might change between the module loads"""
+    module_name = "test_load_module_from_file_reload_no_time_change"
+    module_code = "def get_value(): return {n}"
+
+    module_path = loader.create_module_files(module_name, module_code.format(n=10))
+
+    module = loader.load_module_from_file(module_path)
+
+    assert module.get_value() == 10
+    assert_message_in_log(caplog, f"Monitor '{module_name}' loaded")
+
+    time.sleep(0.1)
+
+    module_path = loader.create_module_files(module_name, module_code.format(n=99))
+
+    module = loader.load_module_from_file(module_path)
+
+    # The value didn't change, even though the module code changed
+    assert module.get_value() == 10
+    assert_message_in_log(caplog, f"Monitor '{module_name}' loaded", count=2)
+
+
 def test_load_module_from_file_reload_replace_variables():
     """'load_module_from_file' should be able to reload modules replacing the previous state for a
     new one"""