Skip to content

Refactor Tkinter GUI#25

Open
abhigyaabs2 wants to merge 3 commits into
Gagandeep-2003:mainfrom
abhigyaabs2:fix/abhigya
Open

Refactor Tkinter GUI#25
abhigyaabs2 wants to merge 3 commits into
Gagandeep-2003:mainfrom
abhigyaabs2:fix/abhigya

Conversation

@abhigyaabs2

Copy link
Copy Markdown
Contributor

This pull request introduces a basic Tkinter-based GUI that provides an interface to run:

  1. Face Detection (face-try.py)
  2. Blink Detection (blinkDetect.py)
  3. A Quit button to exit the app

Updates include:

  1. Added tkinter-based UI with neatly arranged buttons
  2. Integrated subprocess.call() to execute external Python scripts
  3. Handled cross-platform compatibility using sys.executable
  4. Cleaned up unnecessary geometry duplication and improved button styling
  5. Ensured proper import statements (tk module usage)

@thynash

thynash commented Jul 26, 2025

Copy link
Copy Markdown
Collaborator

@abhigyaabs2 please mention the issue number you are solving with this pr so that i can link it to the issue

@abhigyaabs2

abhigyaabs2 commented Jul 27, 2025

Copy link
Copy Markdown
Contributor Author

@thynash I am resolving issue no. #30 that you have assigned me. I have already PR both the contributions/changes. Please check them and let me know if anything else is to be added or changed.

@Gagandeep-2003

Copy link
Copy Markdown
Owner

@thynash I am resolving issue no. #30 that you have assigned me. I have already PR both the contributions/changes. Please check them and let me know if anything else is to be added or changed.

Thanks for working on this issue.
I noticed that instead of updating the existing files (main.py and ui.py), the PR creates new files (main1.py, ui1.py).
For maintainability and to avoid duplicate code, please make changes directly in the existing files rather than creating new ones.
This way, the fix will integrate seamlessly into the main project and be easier to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants