Skip to content

Commit 1f1ae14

Browse files
borisbatclaude
andcommitted
dasLLAMA: PROBE_PATH's default was Windows-only
Copilot round 4, three threads on one issue. The write-cliff probe defaulted to `D:/_wcliff.bin`, which on POSIX is not an absolute path at all — it is a relative `D:` directory that does not exist, so the probe fails confusingly on every non-Windows host rather than writing anywhere. Default is now cwd-relative `_wcliff.bin`, which resolves on every host; the registry entry and the usage line say to point it at the drive under test, which is the whole point of the knob. Also dropped `require strings`, unused since env_int64 replaced the to_int call. Gates: compiles, lint 0 issues, test_env_registry 14/14, ENVIRONMENT.md regenerated. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019ruKZPG8G7SPEUyZtvBzcT
1 parent e8e764f commit 1f1ae14

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

modules/dasLLAMA/ENVIRONMENT.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ Apple Accelerate / AMX float lane. `DASLLAMA_ACCEL` arms the whole group.
140140

141141
| Variable | Type | Default | Effect |
142142
|---|---|---|---|
143-
| `PROBE_PATH` | path | D:/_wcliff.bin | Scratch file the write-cliff probe writes; put it on the drive under test. |
143+
| `PROBE_PATH` | path | _wcliff.bin | Scratch file the write-cliff probe writes, cwd-relative by default; point it at the drive under test. |
144144
| `PROBE_GB` | number | 50 | Gigabytes the write-cliff probe writes before reporting. |
145145
| `DASLLAMA_BENCH_MODEL` | text | tinyllama | Model name for the isolated GEMM bench. |
146146
| `DASLLAMA_BENCH_NTOK` | number | unset | Token count for the isolated GEMM bench. |

modules/dasLLAMA/benchmarks/write_cliff_probe.das

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,9 @@ options gen2
66
// total. The .dlim writer is the caller that hits this: 75 GB at 275 MB/s where a 2.5 GB image
77
// writes at ~1 GB/s.
88
// bin/daslang modules/dasLLAMA/benchmarks/write_cliff_probe.das
9-
// PROBE_GB=50 PROBE_PATH=D:/_wcliff.bin bin/daslang .../write_cliff_probe.das
9+
// PROBE_GB=50 PROBE_PATH=/mnt/nvme/_wcliff.bin bin/daslang .../write_cliff_probe.das
1010

1111
require daslib/fio
12-
require strings
1312
require math
1413
require dasllama/dasllama_env
1514

@@ -19,7 +18,8 @@ let WINDOW_CHUNKS = 32l // one report line per 512 MB
1918
[export]
2019
def main() {
2120
let gb = max(env_int64("PROBE_GB", 50l), 1l)
22-
let path = env_str("PROBE_PATH", "D:/_wcliff.bin")
21+
// cwd-relative so the default works on every host; point it at the drive under test
22+
let path = env_str("PROBE_PATH", "_wcliff.bin")
2323
let chunk_bytes = CHUNK_MB * 1024l * 1024l
2424
let chunks = max(gb * 1024l / CHUNK_MB, 1l)
2525
var buf : array<uint8>

modules/dasLLAMA/dasllama/dasllama_env.das

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -223,8 +223,8 @@ def private reg_vulkan(var o : array<EnvKnob>) {
223223
"Bucket gguf -> image conversion time by kind over the weight walk; one clock pair per tensor.")
224224
k(o, "DASLLAMA_ALLOW_INTERP_LOAD", EnvKind.flag, EnvArea.engine, "off",
225225
"Permit a big gguf load without -jit; the transforms run interpreted, so expect minutes per GB.")
226-
k(o, "PROBE_PATH", EnvKind.path, EnvArea.benchmark, "D:/_wcliff.bin",
227-
"Scratch file the write-cliff probe writes; put it on the drive under test.")
226+
k(o, "PROBE_PATH", EnvKind.path, EnvArea.benchmark, "_wcliff.bin",
227+
"Scratch file the write-cliff probe writes, cwd-relative by default; point it at the drive under test.")
228228
k(o, "PROBE_GB", EnvKind.number, EnvArea.benchmark, "50",
229229
"Gigabytes the write-cliff probe writes before reporting.")
230230
k(o, "DASLLAMA_MM_SMALLD", EnvKind.number, EnvArea.vulkan, "64",

0 commit comments

Comments
 (0)