Commit 9c187c9
accelerate: put the offending value back in the out-of-range warning
Copilot review, #3580. env_int64_min's warning named the constraint but not
the value that broke it, which is the one thing you need to fix a typo'd knob.
This was a regression from this PR. The original printed the raw string:
dasLLAMA: {name} `{raw}` is not an integer >= {min_v} — keeping {def_v}
Delegating the parse to env_int64 dropped `{raw}` — and quietly dropped a
second case with it: env_int64 falls back on unparseable input, so a typo'd
DASLLAMA_ACCEL_MIN_NTOK stopped warning at all and silently did nothing. That
is the exact failure mode this registry exists to prevent.
Both restored with one branch: read the raw value first, then parse with a
sentinel default one below the floor, so unparseable and out-of-range fall
into the same check. An unset knob still returns the default in silence, which
is the registry's documented contract.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent 213da6b commit 9c187c9
1 file changed
Lines changed: 6 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
223 | 223 | | |
224 | 224 | | |
225 | 225 | | |
226 | | - | |
| 226 | + | |
| 227 | + | |
227 | 228 | | |
228 | | - | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
229 | 232 | | |
230 | | - | |
| 233 | + | |
231 | 234 | | |
232 | 235 | | |
233 | 236 | | |
| |||
0 commit comments