relax the go directive to 1.25.0 - #84
Merged
Merged
Conversation
go 1.26.5 forced every go install user onto the newest toolchain patch: the go command auto-switches or refuses when the local toolchain is older than the directive. Nothing in the module needs 1.26 -- the newest constructs are WaitGroup.Go (1.25), SplitSeq and T.Context (1.24) -- and the strictest dependency, the MCP go-sdk, declares 1.25.0, which is also why tidy pins the three-part form rather than a bare 1.25. Verify: go build, go vet (stdversion), go test -race, and lint against a 1.25 language version; CI resolves the toolchain from go.mod and revalidates on an actual 1.25.x.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go 1.26.5madego installdemand the newest toolchain patch (auto-switch or refusal on anything older). Nothing in the module needs 1.26: the newest constructs areWaitGroup.Go(1.25) andSplitSeq/T.Context(1.24), andgo vet's stdversion analyzer is clean at 1.25.1.25.0rather than bare1.25becausego mod tidypins the directive to the strictest dependency (the MCP go-sdk declares1.25.0);.0is the floor of the line, so any 1.25.x+ toolchain installs without forced upgrades.CI resolves its toolchain from
go.mod, so these checks ran on an actual 1.25.x across all three OSes.