test and build against both supported Go lines - #85
Merged
Merged
Conversation
The go directive is the compatibility floor, not the toolchain to validate or ship with. Tests and the goreleaser dry run now run a matrix over 1.25 and 1.26: the floor proves go install works for the oldest supported toolchain, the newest is what releases build with. The publishing build pins 1.26 explicitly -- with the directive lowered, go-version-file would have silently downgraded official binaries to the floor toolchain. Lint stays on the floor, where typechecking is strictest for the module's declared language version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #84:
testmatrix gains a Go axis: 3 OSes x {1.25, 1.26}. The floor provesgo installworks on the oldest supported toolchain; the newest matches what releases ship with.release-dry-runruns the same two-line matrix, so both build paths are proven per toolchain.release.ymlpins1.26explicitly: with the directive lowered,go-version-filewould have silently downgraded official binaries to the floor toolchain.ci-okneeds no changes; it gates on the job, which covers every matrix leg.v1.1.3 (shipping the relaxed directive to
go installusers) follows on merge.