fix Windows path handling in kensai MCP server - #4
Merged
Merged
Conversation
PathIndex imported node:path/posix globally, breaking absolute path construction on Windows -- path.posix.resolve() does not handle drive letters. Use native path module for absRoot resolution, readdir, and stat paths; keep posix path for internal relative path representation. RepoFs.resolve() returned platform-native separators from path.relative(), producing backslash paths on Windows that failed index lookups. Normalize output to forward slashes. Add Windows to CI test matrix (ubuntu + windows x node lts + 26). Fix symlink target in tests to use tmpdir() instead of /tmp.
xobotyi
force-pushed
the
dev-master
branch
4 times, most recently
from
May 26, 2026 12:51
8103c09 to
292f328
Compare
pnpm/action-setup@v4 repo is no longer available on GitHub. Use corepack enable pnpm instead -- the package.json already declares packageManager for corepack to resolve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PathIndexusingnode:path/posixfor absolute filesystem paths --path.posix.resolve()does not handle Windows drive letters. Use nativepathmodule forabsRoot,readdir, andstatpaths; keep posix for internal relative representation.RepoFs.resolve()returning platform-native backslash separators frompath.relative(), breaking index lookups on Windows. Normalize output to forward slashes.windows-latestto CI test matrix (2x2: ubuntu + windows x node lts + 26)./tmptotmpdir().Test plan
ubuntu-latest(existing)windows-latest(new)