feat: use IssueCommentDict schema in get_issue_comments method

- Simplify get_issue_comments to use schema parameter
- Remove fallback logic (handled by schema)
- Update tests to expect schema parameter
- Remove tests for obsolete fallback logic

Author: ivolnistov

src/youtrack_rocket_mcp/api/resources/issues.py

@@ -402,7 +402,7 @@ async def search_issues(self, query: str, limit: int = 10) -> list[Issue]:
 
         return issues
 
-    async def get_issue_comments(self, issue_id: str) -> list[JSONDict]:
+    async def get_issue_comments(self, issue_id: str) -> list[IssueCommentDict]:
         """
         Get comments for an issue.
 
@@ -414,19 +414,7 @@ async def get_issue_comments(self, issue_id: str) -> list[JSONDict]:
         """
         # Request comments with detailed author information
         fields = 'id,created,text,author(id,login,name)'
-        response = await self.client.get(f'issues/{issue_id}/comments?fields={fields}')
-
-        # The response should be a list of comments
-        if isinstance(response, list):
-            return response
-        elif isinstance(response, dict) and 'comments' in response:
-            return response['comments']
-        else:
-            # Fallback: try to get comments as part of issue data
-            issue_response = await self.client.get(f'issues/{issue_id}?fields=comments({fields})')
-            if isinstance(issue_response, dict) and 'comments' in issue_response:
-                return issue_response['comments']
-            return []
+        return await self.client.get(f'issues/{issue_id}/comments?fields={fields}', schema=list[IssueCommentDict])
 
     async def add_comment(self, issue_id: str, text: str) -> IssueCommentDict:
         """

tests/test_issues_api.py

@@ -223,6 +223,8 @@ async def test_create_issue_handles_api_error(issues_client, mock_client):
 @pytest.mark.asyncio
 async def test_get_issue_comments(issues_client, mock_client):
     """Test getting comments for an issue."""
+    from youtrack_rocket_mcp.api.schemas import IssueCommentDict
+
     mock_response = [
         {
             'id': 'comment-1',
@@ -241,9 +243,11 @@ async def test_get_issue_comments(issues_client, mock_client):
 
     result = await issues_client.get_issue_comments('TEST-1')
 
-    # Check API was called correctly
+    # Check API was called correctly with schema
     expected_fields = 'id,created,text,author(id,login,name)'
-    mock_client.get.assert_called_once_with(f'issues/TEST-1/comments?fields={expected_fields}')
+    mock_client.get.assert_called_once_with(
+        f'issues/TEST-1/comments?fields={expected_fields}', schema=list[IssueCommentDict]
+    )
 
     # Check result
     assert result == mock_response
@@ -253,53 +257,6 @@ async def test_get_issue_comments(issues_client, mock_client):
     assert result[0]['author']['login'] == 'john.doe'
 
 
-@pytest.mark.asyncio
-async def test_get_issue_comments_nested_response(issues_client, mock_client):
-    """Test getting comments when API returns nested structure."""
-    mock_comments = [{'id': 'comment-1', 'created': 1234567890, 'text': 'Test comment'}]
-    mock_response = {'comments': mock_comments}
-    mock_client.get.return_value = mock_response
-
-    result = await issues_client.get_issue_comments('TEST-1')
-
-    # Check result extracts comments from nested structure
-    assert result == mock_comments
-
-
-@pytest.mark.asyncio
-async def test_get_issue_comments_fallback_to_issue_data(issues_client, mock_client):
-    """Test fallback to getting comments from issue data."""
-    mock_comments = [{'id': 'comment-1', 'created': 1234567890, 'text': 'Test comment'}]
-
-    # First call returns invalid data, second call (fallback) returns issue with comments
-    mock_client.get.side_effect = [
-        'invalid_response',  # First call fails
-        {'comments': mock_comments},  # Fallback call succeeds
-    ]
-
-    result = await issues_client.get_issue_comments('TEST-1')
-
-    # Check both API calls were made
-    assert mock_client.get.call_count == 2
-    expected_fields = 'id,created,text,author(id,login,name)'
-    mock_client.get.assert_any_call(f'issues/TEST-1/comments?fields={expected_fields}')
-    mock_client.get.assert_any_call(f'issues/TEST-1?fields=comments({expected_fields})')
-
-    # Check result
-    assert result == mock_comments
-
-
-@pytest.mark.asyncio
-async def test_get_issue_comments_empty_response(issues_client, mock_client):
-    """Test getting comments when no comments exist."""
-    mock_client.get.side_effect = ['invalid_response', 'invalid_response']
-
-    result = await issues_client.get_issue_comments('TEST-1')
-
-    # Should return empty list when no valid response
-    assert result == []
-
-
 @pytest.mark.asyncio
 async def test_add_comment(issues_client, mock_client):
     """Test adding a comment to an issue."""